Close web contents modal dialogs on content load start

chrome/browser/printing/print_preview_dialog_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_preview_dialog_controller.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 370 matching lines @@
       if (!waiting_for_new_preview_page_ &&
           transition_type == content::PAGE_TRANSITION_RELOAD &&
           nav_type == content::NAVIGATION_TYPE_EXISTING_PAGE &&
           IsPrintPreviewURL(details->previous_url)) {
         return;
       }
     }
     NOTREACHED();
     return;
   }
-
-  RemoveInitiatorTab(contents);

[Lei Zhang, 2013/06/27 00:31:18]

Once we do this, then maybe we don't even need watch for
NOTIFICATION_NAV_ENTRY_COMMITTED for initiator tabs.

[Mike Wittman, 2013/06/27 00:58:11]

Yes, that's true. It would require a bit more complexity around
AddObservers/RemoveObservers which currently do not distinguish between tab
types for WebContents.

[Lei Zhang, 2013/06/27 02:29:37]

Yes it would. If you don't want to, then just put a TODO(thestig) and I can take
care of it in the future.

[Mike Wittman, 2013/06/27 17:34:04]

Not a problem, added the additional logic to not observe
NOTIFICATION_NAV_ENTRY_COMMITTED for the initiator tab.

 }
 
 WebContents* PrintPreviewDialogController::CreatePrintPreviewDialog(
     WebContents* initiator_tab) {
   base::AutoReset<bool> auto_reset(&is_creating_print_preview_dialog_, true);
   Profile* profile =
       Profile::FromBrowserContext(initiator_tab->GetBrowserContext());
   if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kChromeFrame)) {
     // Chrome Frame only ever runs on the native desktop, so it is safe to
     // create the popup on the native desktop.
@@ skipping 110 matching lines @@
   PrintPreviewUI* print_preview_ui =
       static_cast<PrintPreviewUI*>(preview_dialog->GetWebUI()->GetController());
   if (print_preview_ui)
     print_preview_ui->OnPrintPreviewDialogDestroyed();
 
   preview_dialog_map_.erase(preview_dialog);
   RemoveObservers(preview_dialog);
 }
 
 }  // namespace printing