Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1749303002: Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic (Closed)

Created:
4 years, 9 months ago by danzh1
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, gredner_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@115444705
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic Cut-over from old to new BalsaUrl/HttpRequest interfaces. See CL 113648771 for extended discussion of this change. No functional change intended, not flag-protected. Merge internal change: 115455799 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : git rebase 115444705 #

Patch Set 3 : Revert to Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M net/tools/quic/spdy_balsa_utils.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (0 generated)
danzh1
4 years, 9 months ago (2016-03-01 19:19:13 UTC) #1
Ryan Hamilton
lgtm please edit the CL description (really only important in the final CL) to reflect ...
4 years, 9 months ago (2016-03-02 04:19:10 UTC) #2
danzh1
4 years, 9 months ago (2016-03-04 15:13:02 UTC) #3
On 2016/03/02 04:19:10, Ryan Hamilton wrote:
> lgtm
> 
> please edit the CL description (really only important in the final CL) to
> reflect the actual changes, and not references to internal code which is not
> part of this CL.

change relnote to: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No functio change. In Final cl.

Powered by Google App Engine
This is Rietveld 408576698