Issue 1749303002: Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1749303002: Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic (Closed)

Created:
4 years, 9 months ago by danzh1

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, gredner_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@115444705

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Transition to new BalsaUrl/HttpRequestInfo interfaces in gfe/gfe2/quic Cut-over from old to new BalsaUrl/HttpRequest interfaces. See CL 113648771 for extended discussion of this change. No functional change intended, not flag-protected. Merge internal change: 115455799 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : git rebase 115444705 #

Patch Set 3 : Revert to Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	net/tools/quic/spdy_balsa_utils.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 1752823002 Patch 40001

Dependent Patchsets:

Issue 1745303003 Patch 40001

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm please edit the CL description (really only important in the final CL) to reflect ...

4 years, 9 months ago (2016-03-02 04:19:10 UTC) #2

danzh1

4 years, 9 months ago (2016-03-04 15:13:02 UTC) #3

On 2016/03/02 04:19:10, Ryan Hamilton wrote:
> lgtm
> 
> please edit the CL description (really only important in the final CL) to
> reflect the actual changes, and not references to internal code which is not
> part of this CL.

change relnote to: Switch to unique_ptr<GURL> for request uri in
SpdyBalsaUtils::RequestHeadersToSpdyHeaders(). No functio change. In Final cl.

Expand Messages | Collapse Messages