Issue 1752823002: n/a (QUIC toy client/server changes)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1752823002: n/a (QUIC toy client/server changes) (Closed)

Created:
4 years, 9 months ago by danzh1

Modified:
4 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade

Base URL:
https://chromium.googlesource.com/chromium/src.git@115400573

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

n/a (QUIC toy client/server changes) Adds a QuicSocketUtils::CreateUDPSocket method, and rename the existing client/server CreateUDPSocket methods to be a bit more descriptive. Merge internal change: 115444705 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : git rebase 115400573 #

Patch Set 3 : Revert to Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -77 lines)			Patch
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_client.cc	View	4 chunks	+8 lines, -31 lines	0 comments	Download
M	net/tools/quic/quic_client_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_server.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_server.cc	View	1 chunk	+3 lines, -36 lines	0 comments	Download
M	net/tools/quic/quic_server_bin.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/quic_socket_utils.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_socket_utils.cc	View	1 chunk	+35 lines, -0 lines	0 comments	Download
M	net/tools/quic/test_tools/quic_client_peer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/tools/quic/test_tools/quic_client_peer.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/test_tools/server_thread.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 1751923003 Patch 40001

Dependent Patchsets:

Issue 1749303002 Patch 40001

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages