Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745303003: Remove virtual keyword from QuicSpdyStream::WriteTrailers. (Closed)

Created:
4 years, 9 months ago by danzh1
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@115455799
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove virtual keyword from QuicSpdyStream::WriteTrailers. Merge internal change: 115456160 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : git rebase 115444705 #

Patch Set 3 : Revert to Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/quic/quic_spdy_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1749303002 Patch 40001

Dependent Patchsets:

Issue 1760423002 Patch 20001

Messages

Total messages: 2 (0 generated)
danzh1
4 years, 9 months ago (2016-03-01 19:31:48 UTC) #1
Ryan Hamilton
4 years, 9 months ago (2016-03-02 04:19:18 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698