Move //remoting/remoting_host_win.gypi:* to GN

Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899
Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}

Committed: https://crrev.com/0359bb227c582cfd550bf48cf18d6e65c7c15489
Cr-Commit-Position: refs/heads/master@{#384606}

[Hzj_jie, 2016-03-01 07:07:44]

Description was changed from

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899
==========

to

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899
==========

[Hzj_jie, 2016-03-01 07:07:44]

zijiehe@chromium.org changed reviewers:
+ jamiewalch@chromium.org, sergeyu@chromium.org

[Sergey Ulanov, 2016-03-01 20:26:43]

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:663: # TODO(zijiehe): Why version file strings are not
public in GN?
I think GN does have variables for the version, see
https://code.google.com/p/chromium/codesearch#chromium/src/build/util/version...

It's already used in this file to pass VERSION define when compiling the host.
Or maybe I just don't understand this TODO.

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:833: if (((is_mac && is_chrome_branded) || is_win) &&
is_official_build) {
What's the reason it needs to be chrome-branded on mac, but not on windows?

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:870: assert(false, "not implemented on mac or win yet")
nit: update the message

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
File remoting/host/gen_remoting_lib_rc.py (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
remoting/host/gen_remoting_lib_rc.py:10: f.write('1 typelib
"remoting/host/chromoting_lib.tlb"')
Why do we need this script? it looks like it just generates a file with this one
line. Can we just have one static file instead of this script?

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_enable.gni
File remoting/remoting_enable.gni (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_enable.gn...
remoting/remoting_enable.gni:18: if (is_win) {
Merge this with the condition below?

I.e. it will become
if (is_win || (is_linux && !is_chromeos && use_x11)) {
  ...
}

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_host.gni
File remoting/remoting_host.gni (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_host.gni#...
remoting/remoting_host.gni:11: enable_me2me_host = is_win || (use_x11 &&
!is_chromeos)
So we have remoting_enable.gni and remoting_host.gni. They both just define
these two variables, but formatted differently. It makes no sense to keep them
both. Remove this file and keep remoting_enable.gni?

[Hzj_jie, 2016-03-02 08:27:29]

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:663: # TODO(zijiehe): Why version file strings are not
public in GN?
On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> I think GN does have variables for the version, see
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/util/version...
> 
> It's already used in this file to pass VERSION define when compiling the host.
> Or maybe I just don't understand this TODO.

Yes, thank you. But //build/util/LASTCHANGE is not exported.

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:833: if (((is_mac && is_chrome_branded) || is_win) &&
is_official_build) {
On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> What's the reason it needs to be chrome-branded on mac, but not on windows?

It's the combination of,
https://cs.corp.google.com/clankium/src/remoting/remoting.gyp?rcl=0&l=63
and,
https://cs.corp.google.com/cobalt/build/common.gypi?rcl=0&l=1226
But, yes, it's out of date, I should remove is_win, since we are building
remoting_host.exe on windows with a totally different logic.

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:870: assert(false, "not implemented on mac or win yet")
On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> nit: update the message

Done.

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
File remoting/host/gen_remoting_lib_rc.py (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
remoting/host/gen_remoting_lib_rc.py:10: f.write('1 typelib
"remoting/host/chromoting_lib.tlb"')
On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> Why do we need this script? it looks like it just generates a file with this
one
> line. Can we just have one static file instead of this script?

Maybe not, I copied the logic from gyp target
https://cs.corp.google.com/clankium/src/remoting/remoting_host_win.gypi?rcl=0...
I believe the logic will impact the time stamp of the file, and trigger its
dependencies to be rebuilt by ninja.

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_enable.gni
File remoting/remoting_enable.gni (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_enable.gn...
remoting/remoting_enable.gni:18: if (is_win) {
On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> Merge this with the condition below?
> 
> I.e. it will become
> if (is_win || (is_linux && !is_chromeos && use_x11)) {
>   ...
> }

Done.

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_host.gni
File remoting/remoting_host.gni (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/remoting_host.gni#...
remoting/remoting_host.gni:11: enable_me2me_host = is_win || (use_x11 &&
!is_chromeos)
On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> So we have remoting_enable.gni and remoting_host.gni. They both just define
> these two variables, but formatted differently. It makes no sense to keep them
> both. Remove this file and keep remoting_enable.gni?

Sure, I have not noticed that these two files are identical. It's interesting.

[Sergey Ulanov, 2016-03-02 20:46:43]

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:660: "win/version.rc.jinja2",
Should remoting_lib.rc be in this list?

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
File remoting/host/gen_remoting_lib_rc.py (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
remoting/host/gen_remoting_lib_rc.py:10: f.write('1 typelib
"remoting/host/chromoting_lib.tlb"')
On 2016/03/02 08:27:29, Hzj_jie wrote:
> On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> > Why do we need this script? it looks like it just generates a file with this
> one
> > line. Can we just have one static file instead of this script?
> 
> Maybe not, I copied the logic from gyp target
>
https://cs.corp.google.com/clankium/src/remoting/remoting_host_win.gypi?rcl=0...
> I believe the logic will impact the time stamp of the file, and trigger its
> dependencies to be rebuilt by ninja.

I see. This looks like an ugly hack. We want this file to be rebuild whenever
chromoting_lib.tlb changes. Maybe we can avoid this hack GN. I think it should
be possible to fix this by adding  remoting/host/chromoting_lib.tlb as a source
for remoting_windows_resources.
If that doesn't work then please copy the comment from gyp here.

[Hzj_jie, 2016-03-03 09:06:35]

Resolve codereview comments

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/BUILD.gn#newc...
remoting/host/BUILD.gn:660: "win/version.rc.jinja2",
On 2016/03/02 20:46:43, Sergey Ulanov wrote:
> Should remoting_lib.rc be in this list?

No, seems not, gn have only foreach_action, without extension parameter to
select files based on extension.

So current way is,
Change to chromoting_lib_idl.templ triggers both generate_idl and
remoting_lib_rc (newly added)

generate_idl -> remoting_lib_idl -> (remoting_lib_ps, remoting_core, host)

remoting_lib_rc -> remoting_core

So looks like we do not need remoting_lib_rc to trigger remoting_core to be
rebuilt. I will remove it and see if everything works.

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
File remoting/host/gen_remoting_lib_rc.py (right):

https://codereview.chromium.org/1749053002/diff/1/remoting/host/gen_remoting_...
remoting/host/gen_remoting_lib_rc.py:10: f.write('1 typelib
"remoting/host/chromoting_lib.tlb"')
On 2016/03/02 20:46:43, Sergey Ulanov wrote:
> On 2016/03/02 08:27:29, Hzj_jie wrote:
> > On 2016/03/01 20:26:43, Sergey Ulanov wrote:
> > > Why do we need this script? it looks like it just generates a file with
this
> > one
> > > line. Can we just have one static file instead of this script?
> > 
> > Maybe not, I copied the logic from gyp target
> >
>
https://cs.corp.google.com/clankium/src/remoting/remoting_host_win.gypi?rcl=0...
> > I believe the logic will impact the time stamp of the file, and trigger its
> > dependencies to be rebuilt by ninja.
> 
> I see. This looks like an ugly hack. We want this file to be rebuild whenever
> chromoting_lib.tlb changes. Maybe we can avoid this hack GN. I think it should
> be possible to fix this by adding  remoting/host/chromoting_lib.tlb as a
source
> for remoting_windows_resources.
> If that doesn't work then please copy the comment from gyp here.

Updated, please see my comments in remoting/host/BUILD.gn file.

[Sergey Ulanov, 2016-03-04 22:27:04]

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:406: # GYP version:
remoting/remoting_host_win.gypi:remoting_lib_rc
Move this comment to .gypi file next to remoting_lib_rc?

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:520: "chromoting_lib.rc",
Does this file get rebuilt when you change chromoting_lib_idl.templ?
chromoting_lib.rc depends on remoting_lib.idl and I'm not sure if GN knows about
that dependency.

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
File remoting/host/chromoting_lib.rc (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
remoting/host/chromoting_lib.rc:1: 1 typelib "remoting/host/chromoting_lib.tlb"
I think remoting/host/win would be more appropriate directory for this file
because it's windows-specific.
Also please add copyright header here, similar to what we have in
core.rc.jinja2.

[Hzj_jie, 2016-03-09 18:11:29]

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:406: # GYP version:
remoting/remoting_host_win.gypi:remoting_lib_rc
On 2016/03/04 22:27:03, Sergey Ulanov wrote:
> Move this comment to .gypi file next to remoting_lib_rc?

Done.

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:520: "chromoting_lib.rc",
On 2016/03/04 22:27:03, Sergey Ulanov wrote:
> Does this file get rebuilt when you change chromoting_lib_idl.templ?
> chromoting_lib.rc depends on remoting_lib.idl and I'm not sure if GN knows
about
> that dependency.

My understanding is, this target depends on remoting_lib_idl, which depends on
generate_idl. And generate_idl target will rebuild chromoting_lib.idl when
win/chromoting_lib_idl.templ changed.

But unfortunately my windows machine is not ready (The one in Beijing has been
recycled, and the one here has not been sent to me.), I cannot verify my
understanding for now.

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
File remoting/host/chromoting_lib.rc (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
remoting/host/chromoting_lib.rc:1: 1 typelib "remoting/host/chromoting_lib.tlb"
On 2016/03/04 22:27:03, Sergey Ulanov wrote:
> I think remoting/host/win would be more appropriate directory for this file
> because it's windows-specific.
> Also please add copyright header here, similar to what we have in
> core.rc.jinja2.

AFAIK, tlb is a type libraries generated automatically by VC compiler, i.e. the
file location depends on the source code. We cannot change it without moving
source code to win also.

[Hzj_jie, 2016-03-09 22:01:18]

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:520: "chromoting_lib.rc",
On 2016/03/09 18:11:29, Hzj_jie wrote:
> On 2016/03/04 22:27:03, Sergey Ulanov wrote:
> > Does this file get rebuilt when you change chromoting_lib_idl.templ?
> > chromoting_lib.rc depends on remoting_lib.idl and I'm not sure if GN knows
> about
> > that dependency.
> 
> My understanding is, this target depends on remoting_lib_idl, which depends on
> generate_idl. And generate_idl target will rebuild chromoting_lib.idl when
> win/chromoting_lib_idl.templ changed.
> 
> But unfortunately my windows machine is not ready (The one in Beijing has been
> recycled, and the one here has not been sent to me.), I cannot verify my
> understanding for now.

Just tried on Joe's machine, this target will be rebuilt after changing
chromoting_lib_idl.templ.

[Sergey Ulanov, 2016-03-10 01:26:26]

LGTM, but please see my comment. I think it should be possible to move the .rc
file to remoting/host/win

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/BUILD.gn#...
remoting/host/BUILD.gn:520: "chromoting_lib.rc",
On 2016/03/09 22:01:18, Hzj_jie wrote:
> Just tried on Joe's machine, this target will be rebuilt after changing
> chromoting_lib_idl.templ.

great!

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
File remoting/host/chromoting_lib.rc (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
remoting/host/chromoting_lib.rc:1: 1 typelib "remoting/host/chromoting_lib.tlb"
On 2016/03/09 18:11:29, Hzj_jie wrote:
> On 2016/03/04 22:27:03, Sergey Ulanov wrote:
> > I think remoting/host/win would be more appropriate directory for this file
> > because it's windows-specific.
> > Also please add copyright header here, similar to what we have in
> > core.rc.jinja2.
> 
> AFAIK, tlb is a type libraries generated automatically by VC compiler, i.e.
the
> file location depends on the source code. We cannot change it without moving
> source code to win also.

My comment was about this .rc file, not the .tlb file.

[Hzj_jie, 2016-03-10 02:23:26]

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
File remoting/host/chromoting_lib.rc (right):

https://codereview.chromium.org/1749053002/diff/60001/remoting/host/chromotin...
remoting/host/chromoting_lib.rc:1: 1 typelib "remoting/host/chromoting_lib.tlb"
On 2016/03/10 01:26:26, Sergey Ulanov wrote:
> On 2016/03/09 18:11:29, Hzj_jie wrote:
> > On 2016/03/04 22:27:03, Sergey Ulanov wrote:
> > > I think remoting/host/win would be more appropriate directory for this
file
> > > because it's windows-specific.
> > > Also please add copyright header here, similar to what we have in
> > > core.rc.jinja2.
> > 
> > AFAIK, tlb is a type libraries generated automatically by VC compiler, i.e.
> the
> > file location depends on the source code. We cannot change it without moving
> > source code to win also.
> 
> My comment was about this .rc file, not the .tlb file.

I see, my bad.

[Sergey Ulanov, 2016-03-10 06:05:18]

lgtm

[Hzj_jie, 2016-03-10 17:12:39]

The CQ bit was checked by zijiehe@chromium.org

[commit-bot: I haz the power, 2016-03-10 17:12:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749053002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749053002/120001

[commit-bot: I haz the power, 2016-03-10 17:18:25]

Description was changed from

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899
==========

to

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899
==========

[commit-bot: I haz the power, 2016-03-10 17:18:27]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-10 17:19:43]

Description was changed from

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899
==========

to

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899

Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}
==========

[commit-bot: I haz the power, 2016-03-10 17:19:44]

Patchset 7 (id:??) landed as
https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}

[alexmos, 2016-03-10 17:51:44]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/1778313003/ by alexmos@chromium.org.

The reason for reverting is: Seems to have broken compile on Win8 GN:
https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/buil...
.

[Hzj_jie, 2016-03-10 19:12:55]

Description was changed from

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899

Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}
==========

to

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899

Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}
==========

[Nico, 2016-03-21 22:55:24]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-21 22:55:25]

https://codereview.chromium.org/1749053002/diff/340001/remoting/host/BUILD.gn
File remoting/host/BUILD.gn (right):

https://codereview.chromium.org/1749053002/diff/340001/remoting/host/BUILD.gn...
remoting/host/BUILD.gn:411: ]
This doesn't work. You need to put this into its own config, and then depend on
that, else the flags won't be ordered right. See e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/mesa/B...

[Hzj_jie, 2016-03-23 18:40:05]

zijiehe@chromium.org changed reviewers:
+ alexmos@chromium.org

[Hzj_jie, 2016-03-23 18:40:06]

Regarding debug build break, we are using MD(dynamically link to dlls) instead
of MT(statically link to libs) by default in debug mode. So there are two
choices,
1. Change source files this CL impacted, to meet dynamic linkage requirement for
Windows and VC.
2. Disable dynamic linkage as what we have done in gyp.

[Hzj_jie, 2016-03-28 22:40:45]

With help from Bruce, Brett, Dirk and Scott, now all the blocking issues are
resolved. This change is ready to review again.

[Hzj_jie, 2016-03-30 18:37:02]

Will go ahead to submit this change if you do not have other concerns.

[Nico, 2016-03-30 18:46:34]

Oh, I didn't realize you were waiting for me (tip: when pinging someone, always
say "name: ping" to prevent this type of misunderstanding).

Since lots of people who know build stuff very well helped you, I'm sure this is
fine. I added a gn component try bot (win_clang_x64_dbg), if that comes back
green feel free to land.

[Hzj_jie, 2016-03-30 18:48:32]

Thank you, trying.

[Hzj_jie, 2016-03-30 20:59:42]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-03-30 20:59:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1749053002/#ps730001
(title: "Redo last changes")

[commit-bot: I haz the power, 2016-03-30 21:00:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749053002/730001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749053002/730001

[commit-bot: I haz the power, 2016-03-30 21:10:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-30 21:10:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Hzj_jie, 2016-03-30 23:40:15]

zijiehe@chromium.org changed reviewers:
+ bartfab@chromium.org

[Hzj_jie, 2016-03-30 23:41:09]

Bartosz, would you please have a look at this change, I have added prefs as
dependency of components test support target.

[Hzj_jie, 2016-03-31 16:30:36]

zijiehe@chromium.org changed reviewers:
+ atwilson@chromium.org

[Hzj_jie, 2016-03-31 16:32:46]

+Drew, Bartosz has not responded.

[bartfab (slow), 2016-04-01 15:02:50]

On 2016/03/31 16:32:46, Hzj_jie wrote:
> +Drew, Bartosz has not responded.

Sorry, I know very little about gyp/gn. Which bit exactly would you want me to
look at?

[Hzj_jie, 2016-04-01 16:39:57]

On 2016/04/01 15:02:50, bartfab (slow) wrote:
> On 2016/03/31 16:32:46, Hzj_jie wrote:
> > +Drew, Bartosz has not responded.
> 
> Sorry, I know very little about gyp/gn. Which bit exactly would you want me to
> look at?

Hi, Bartosz, to unblock this change (for remoting), I have removed the change in
components folder in the last iteration. My proposal is in the last iteration, @
https://codereview.chromium.org/1749053002/diff/730001/components/policy/BUIL...,
i.e. components/policy:test_support should also include components/prefs as
public_deps.

No matter, it's not hurry, remoting:unittests can actively depend on prefs also.

[Hzj_jie, 2016-04-01 16:40:08]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-04-01 16:40:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1749053002/#ps750001
(title: "Move changes in components folder to remoting folder.")

[commit-bot: I haz the power, 2016-04-01 16:40:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749053002/750001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749053002/750001

[commit-bot: I haz the power, 2016-04-01 16:46:44]

Description was changed from

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899

Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}
==========

to

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899

Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}
==========

[commit-bot: I haz the power, 2016-04-01 16:46:46]

Committed patchset #39 (id:750001)

[commit-bot: I haz the power, 2016-04-01 16:48:19]

Description was changed from

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899

Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}
==========

to

==========
Move //remoting/remoting_host_win.gypi:* to GN

BUG=512899

Committed: https://crrev.com/ed559bd1594477689d0de32f660e0e37d62a5247
Cr-Commit-Position: refs/heads/master@{#380425}

Committed: https://crrev.com/0359bb227c582cfd550bf48cf18d6e65c7c15489
Cr-Commit-Position: refs/heads/master@{#384606}
==========

[commit-bot: I haz the power, 2016-04-01 16:48:20]

Patchset 39 (id:??) landed as
https://crrev.com/0359bb227c582cfd550bf48cf18d6e65c7c15489
Cr-Commit-Position: refs/heads/master@{#384606}