remoting/remoting_host.gni - Issue 1749053002: Move //remoting/remoting_host_win.gypi:* to GN

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/remoting_host.gni

Issue 1749053002: Move //remoting/remoting_host_win.gypi:* to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//build/config/ui.gni")	5 import("//build/config/ui.gni")

6	6

7 # TODO(GYP): make remoting hosts work on win and mac	7 # TODO(GYP): make remoting hosts work on win and mac

8 # enable_remoting_host = is_win \|\| is_mac \|\| is_chromeos \|\| use_x11	8 # enable_remoting_host = is_win \|\| is_mac \|\| is_chromeos \|\| use_x11

9 # enable_me2me_host = is_win \|\| is_mac \|\| (use_x11 && !is_chromeos)	9 # enable_me2me_host = is_win \|\| is_mac \|\| (use_x11 && !is_chromeos)

10 enable_remoting_host = is_chromeos \|\| use_x11	10 enable_remoting_host = is_win \|\| is_chromeos \|\| use_x11

11 enable_me2me_host = use_x11 && !is_chromeos	11 enable_me2me_host = is_win \|\| (use_x11 && !is_chromeos)
	Sergey Ulanov 2016/03/01 20:26:43 So we have remoting_enable.gni and remoting_host.g So we have remoting_enable.gni and remoting_host.gni. They both just define these two variables, but formatted differently. It makes no sense to keep them both. Remove this file and keep remoting_enable.gni? Hzj_jie 2016/03/02 08:27:29 Sure, I have not noticed that these two files are Show quoted text On 2016/03/01 20:26:43, Sergey Ulanov wrote: > So we have remoting_enable.gni and remoting_host.gni. They both just define > these two variables, but formatted differently. It makes no sense to keep them > both. Remove this file and keep remoting_enable.gni? Sure, I have not noticed that these two files are identical. It's interesting.
OLD	NEW

« remoting/remoting_enable.gni ('K') | « remoting/remoting_enable.gni ('k') | remoting/remoting_host_win.gypi » ('j') | no next file with comments »