remoting/host/gen_remoting_lib_rc.py - Issue 1749053002: Move //remoting/remoting_host_win.gypi:* to GN

Side by Side Diff: remoting/host/gen_remoting_lib_rc.py

Issue 1749053002: Move //remoting/remoting_host_win.gypi:* to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

	2 #

2 # Copyright 2016 The Chromium Authors. All rights reserved.	3 # Copyright 2016 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	5 # found in the LICENSE file.

5	6

6 import config	7 import sys

7 import crash_server	8

8 import exceptions	9 f = open(sys.argv[1], 'w')

9 import integration_test	10 f.write('1 typelib "remoting/host/chromoting_lib.tlb"')
	Sergey Ulanov 2016/03/01 20:26:43 Why do we need this script? it looks like it just Why do we need this script? it looks like it just generates a file with this one line. Can we just have one static file instead of this script? Hzj_jie 2016/03/02 08:27:29 Maybe not, I copied the logic from gyp target http Show quoted text On 2016/03/01 20:26:43, Sergey Ulanov wrote: > Why do we need this script? it looks like it just generates a file with this one > line. Can we just have one static file instead of this script? Maybe not, I copied the logic from gyp target https://cs.corp.google.com/clankium/src/remoting/remoting_host_win.gypi?rcl=0... I believe the logic will impact the time stamp of the file, and trigger its dependencies to be rebuilt by ninja. Sergey Ulanov 2016/03/02 20:46:43 I see. This looks like an ugly hack. We want this Show quoted text On 2016/03/02 08:27:29, Hzj_jie wrote: > On 2016/03/01 20:26:43, Sergey Ulanov wrote: > > Why do we need this script? it looks like it just generates a file with this > one > > line. Can we just have one static file instead of this script? > > Maybe not, I copied the logic from gyp target > https://cs.corp.google.com/clankium/src/remoting/remoting_host_win.gypi?rcl=0... > I believe the logic will impact the time stamp of the file, and trigger its > dependencies to be rebuilt by ninja. I see. This looks like an ugly hack. We want this file to be rebuild whenever chromoting_lib.tlb changes. Maybe we can avoid this hack GN. I think it should be possible to fix this by adding remoting/host/chromoting_lib.tlb as a source for remoting_windows_resources. If that doesn't work then please copy the comment from gyp here. Hzj_jie 2016/03/03 09:06:35 Updated, please see my comments in remoting/host/B Show quoted text On 2016/03/02 20:46:43, Sergey Ulanov wrote: > On 2016/03/02 08:27:29, Hzj_jie wrote: > > On 2016/03/01 20:26:43, Sergey Ulanov wrote: > > > Why do we need this script? it looks like it just generates a file with this > > one > > > line. Can we just have one static file instead of this script? > > > > Maybe not, I copied the logic from gyp target > > > https://cs.corp.google.com/clankium/src/remoting/remoting_host_win.gypi?rcl=0... > > I believe the logic will impact the time stamp of the file, and trigger its > > dependencies to be rebuilt by ninja. > > I see. This looks like an ugly hack. We want this file to be rebuild whenever > chromoting_lib.tlb changes. Maybe we can avoid this hack GN. I think it should > be possible to fix this by adding remoting/host/chromoting_lib.tlb as a source > for remoting_windows_resources. > If that doesn't work then please copy the comment from gyp here. Updated, please see my comments in remoting/host/BUILD.gn file.
10 import process	11 f.close()

11 import report

12 import util

OLD	NEW

« remoting/host/BUILD.gn ('K') | « remoting/host/BUILD.gn ('k') | remoting/host/it2me/BUILD.gn » ('j') | remoting/remoting_enable.gni » ('J')