Issue 17485002: Fix stack frame reconstruction for generators with formal arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17485002: Fix stack frame reconstruction for generators with formal arguments (Closed)

Created:
7 years, 6 months ago by wingo

Modified:
7 years, 6 months ago

Reviewers:
Michael Starzinger, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix stack frame reconstruction for generators with formal arguments The formal parameter count was always being treated as an untagged integer, but it is actually a Smi on ia32 and arm. R=mstarzinger@chromium.org BUG=v8:2355 TEST=mjsunit/harmony/generators-iteration Committed: http://code.google.com/p/v8/source/detail?r=15230

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -2 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/harmony/generators-iteration.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wingo

7 years, 6 months ago (2013-06-20 10:48:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15230 (presubmit successful).

Expand Messages | Collapse Messages