Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 17485002: Fix stack frame reconstruction for generators with formal arguments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2114 matching lines...) Expand 10 before | Expand all | Expand 10 after
2125 __ ldr(r2, FieldMemOperand(r1, JSGeneratorObject::kReceiverOffset)); 2125 __ ldr(r2, FieldMemOperand(r1, JSGeneratorObject::kReceiverOffset));
2126 __ push(r2); 2126 __ push(r2);
2127 2127
2128 // Push holes for the rest of the arguments to the generator function. 2128 // Push holes for the rest of the arguments to the generator function.
2129 __ ldr(r3, FieldMemOperand(r4, JSFunction::kSharedFunctionInfoOffset)); 2129 __ ldr(r3, FieldMemOperand(r4, JSFunction::kSharedFunctionInfoOffset));
2130 __ ldr(r3, 2130 __ ldr(r3,
2131 FieldMemOperand(r3, SharedFunctionInfo::kFormalParameterCountOffset)); 2131 FieldMemOperand(r3, SharedFunctionInfo::kFormalParameterCountOffset));
2132 __ LoadRoot(r2, Heap::kTheHoleValueRootIndex); 2132 __ LoadRoot(r2, Heap::kTheHoleValueRootIndex);
2133 Label push_argument_holes, push_frame; 2133 Label push_argument_holes, push_frame;
2134 __ bind(&push_argument_holes); 2134 __ bind(&push_argument_holes);
2135 __ sub(r3, r3, Operand(1), SetCC); 2135 __ sub(r3, r3, Operand(Smi::FromInt(1)), SetCC);
2136 __ b(mi, &push_frame); 2136 __ b(mi, &push_frame);
2137 __ push(r2); 2137 __ push(r2);
2138 __ jmp(&push_argument_holes); 2138 __ jmp(&push_argument_holes);
2139 2139
2140 // Enter a new JavaScript frame, and initialize its slots as they were when 2140 // Enter a new JavaScript frame, and initialize its slots as they were when
2141 // the generator was suspended. 2141 // the generator was suspended.
2142 Label resume_frame; 2142 Label resume_frame;
2143 __ bind(&push_frame); 2143 __ bind(&push_frame);
2144 __ bl(&resume_frame); 2144 __ bl(&resume_frame);
2145 __ jmp(&done); 2145 __ jmp(&done);
(...skipping 2747 matching lines...) Expand 10 before | Expand all | Expand 10 after
4893 *context_length = 0; 4893 *context_length = 0;
4894 return previous_; 4894 return previous_;
4895 } 4895 }
4896 4896
4897 4897
4898 #undef __ 4898 #undef __
4899 4899
4900 } } // namespace v8::internal 4900 } } // namespace v8::internal
4901 4901
4902 #endif // V8_TARGET_ARCH_ARM 4902 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698