src/ia32/full-codegen-ia32.cc - Issue 17485002: Fix stack frame reconstruction for generators with formal arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 17485002: Fix stack frame reconstruction for generators with formal arguments (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 54e9eaf1d60969a65cd0ac17dd852e1a3bcf411e..5ce7686e3c384d97ceff946b01b196ca8e1733e0 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2091,7 +2091,7 @@ void FullCodeGenerator::EmitGeneratorResume(Expression *generator,

__ mov(ecx, isolate()->factory()->the_hole_value());

Label push_argument_holes, push_frame;

__ bind(&push_argument_holes);

- __ sub(edx, Immediate(1));

+ __ sub(edx, Immediate(Smi::FromInt(1)));

__ j(carry, &push_frame);

__ push(ecx);

__ jmp(&push_argument_holes);

« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | test/mjsunit/harmony/generators-iteration.js » ('j') | no next file with comments »