Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Unified Diff: xfa/src/fgas/src/font/fx_stdfontmgr.h

Issue 1747123002: Fix and enable lint checks. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fgas/src/font/fx_stdfontmgr.h
diff --git a/xfa/src/fgas/src/font/fx_stdfontmgr.h b/xfa/src/fgas/src/font/fx_stdfontmgr.h
index 1314d2f4657ba6f8c2b98d79837bb0bfb121dcc8..16d3041a1dafdf07374962be80f2a8e242dcffb5 100644
--- a/xfa/src/fgas/src/font/fx_stdfontmgr.h
+++ b/xfa/src/fgas/src/font/fx_stdfontmgr.h
@@ -108,13 +108,13 @@ struct FX_FontDescriptorInfo {
int32_t nPenalty;
bool operator>(const FX_FontDescriptorInfo& x) {
Tom Sepez 2016/03/01 17:38:06 nit: const methods? e.g. bool operator>(const F
dsinclair 2016/03/01 18:11:51 Done.
return nPenalty > x.nPenalty;
- };
+ }
bool operator<(const FX_FontDescriptorInfo& x) {
return nPenalty < x.nPenalty;
- };
+ }
bool operator==(const FX_FontDescriptorInfo& x) {
return nPenalty == x.nPenalty;
- };
+ }
};
typedef CFX_ArrayTemplate<FX_FontDescriptorInfo> CFX_FontDescriptorInfos;
@@ -131,7 +131,7 @@ struct FX_HandleParentPath {
class CFX_FontSourceEnum_File : public IFX_FontSourceEnum {
public:
CFX_FontSourceEnum_File();
- virtual void Release() { delete this; };
+ virtual void Release() { delete this; }
virtual FX_POSITION GetStartPosition(void* pUserData = NULL);
virtual IFX_FileAccess* GetNext(FX_POSITION& pos, void* pUserData = NULL);

Powered by Google App Engine
This is Rietveld 408576698