Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: xfa/src/fgas/src/layout/fx_rtfbreak.h

Issue 1747123002: Fix and enable lint checks. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fgas/src/layout/fx_rtfbreak.h
diff --git a/xfa/src/fgas/src/layout/fx_rtfbreak.h b/xfa/src/fgas/src/layout/fx_rtfbreak.h
index a54b83bf3dbe5b42aa8a9f529462630237f05818..b4a492ae0d2fd2d91b89534487282f2c6004da68 100644
--- a/xfa/src/fgas/src/layout/fx_rtfbreak.h
+++ b/xfa/src/fgas/src/layout/fx_rtfbreak.h
@@ -69,8 +69,8 @@ class CFX_RTFBreak : public IFX_RTFBreak {
CFX_RTFBreak(FX_DWORD dwPolicies);
~CFX_RTFBreak();
void Release() override { delete this; }
- void SetLineBoundary(FX_FLOAT fLineStart, FX_FLOAT fLineEnd) override final;
- void SetLineStartPos(FX_FLOAT fLinePos) override final;
+ void SetLineBoundary(FX_FLOAT fLineStart, FX_FLOAT fLineEnd) final;
Tom Sepez 2016/03/01 17:38:06 So is the issue that override and final are incomp
dsinclair 2016/03/01 18:11:52 Yea, according to cpplint override final is redund
+ void SetLineStartPos(FX_FLOAT fLinePos) final;
FX_DWORD GetLayoutStyles() const override { return m_dwLayoutStyles; }
void SetLayoutStyles(FX_DWORD dwLayoutStyles) override;
void SetFont(IFX_Font* pFont) override;

Powered by Google App Engine
This is Rietveld 408576698