fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp - Issue 1747123002: Fix and enable lint checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

Issue 1747123002: Fix and enable lint checks. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

index f9bf1705546281d54288bce44407398469883306..4e0c3f7ffc057d323cb4d72710025233f81d515a 100644

--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

@@ -1046,9 +1046,9 @@ FX_BOOL CPDFXFA_Document::_MailToInfo(CFX_WideString& csURL,

CFX_WideString tmp;

if (pos == -1) {

pos = srcURL.Find(L'@', 0);

- if (pos == -1)

+ if (pos == -1) {

return FALSE;

- else {

+ } else {

Tom Sepez 2016/03/01 17:38:06 else after return not needed.

dsinclair 2016/03/01 18:11:51 Done.

tmp = srcURL.Right(csURL.GetLength() - 7);

tmp.TrimLeft();

tmp.TrimRight();