Fix and enable lint checks.

Fix and enable lint checks.

This CL fixes and enables:
  * readability/namespace
  * readability/multiline_string
  * readability/multiline_comment
  * readability/inheritance
  * readability/function
  * readability/braces

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/738b08ce6b9f80d93b815411b47c2b11c2f090f6

[dsinclair, 2016-03-01 14:55:34]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-03-01 14:55:35]

PTAL.

[Tom Sepez, 2016-03-01 17:38:06]

https://codereview.chromium.org/1747123002/diff/1/core/include/fpdfapi/fpdf_r...
File core/include/fpdfapi/fpdf_resource.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/include/fpdfapi/fpdf_r...
core/include/fpdfapi/fpdf_resource.h:169: void
LoadFontDescriptor(CPDF_Dictionary* dict);
nit: |pDict| just to be consistent.

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/font_int.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/font_int.h:93: void ParseWord(const CFX_ByteStringC&
str);
nit: pMap

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/pageint.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/pageint.h:141: void AddForm(CPDF_Stream* stream);
Nit: pStream

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/pageint.h:146: void SaveStates(CPDF_AllStates*
state);
pStates.

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp:84: if (width % 8 &&
(pBuf[width / 8] & (0xff << (8 - width % 8))))
nit: or just
  return (width % 8 && (pBuf[width / 8] & (0xff << (8 - width % 8))));

Also, I might parnethesize ase

   (width % 8) && (pBuf[width / 8] & (0xff << (8 - width % 8)));

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/render_int.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/render_int.h:501: void ReleaseBitmap(CFX_DIBitmap*
bitmap) const;
pBitmap

https://codereview.chromium.org/1747123002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1747123002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:1051: } else {
else after return not needed.

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/font/fx_st...
File xfa/src/fgas/src/font/fx_stdfontmgr.h (right):

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/font/fx_st...
xfa/src/fgas/src/font/fx_stdfontmgr.h:109: bool operator>(const
FX_FontDescriptorInfo& x) {
nit: const methods? e.g.

  bool operator>(const FX_FontDescriptorInfo& x) const {

Maybe change |x| to |other|?

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.cpp (right):

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.cpp:552: } else {
else if

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.h (right):

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.h:72: void SetLineBoundary(FX_FLOAT
fLineStart, FX_FLOAT fLineEnd) final;
So is the issue that override and final are incompatible?  We're usually not big
fans of final, might prefer to keep override?

[dsinclair, 2016-03-01 18:11:52]

https://codereview.chromium.org/1747123002/diff/1/core/include/fpdfapi/fpdf_r...
File core/include/fpdfapi/fpdf_resource.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/include/fpdfapi/fpdf_r...
core/include/fpdfapi/fpdf_resource.h:169: void
LoadFontDescriptor(CPDF_Dictionary* dict);
On 2016/03/01 17:38:05, Tom Sepez wrote:
> nit: |pDict| just to be consistent.

Done.

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/font_int.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/font_int.h:93: void ParseWord(const CFX_ByteStringC&
str);
On 2016/03/01 17:38:05, Tom Sepez wrote:
> nit: pMap

Done.

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/pageint.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/pageint.h:141: void AddForm(CPDF_Stream* stream);
On 2016/03/01 17:38:05, Tom Sepez wrote:
> Nit: pStream

Done.

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/pageint.h:146: void SaveStates(CPDF_AllStates*
state);
On 2016/03/01 17:38:05, Tom Sepez wrote:
> pStates.

Done.

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp:84: if (width % 8 &&
(pBuf[width / 8] & (0xff << (8 - width % 8))))
On 2016/03/01 17:38:05, Tom Sepez wrote:
> nit: or just
>   return (width % 8 && (pBuf[width / 8] & (0xff << (8 - width % 8))));
> 
> Also, I might parnethesize ase
> 
>    (width % 8) && (pBuf[width / 8] & (0xff << (8 - width % 8)));

Done.

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/render_int.h (right):

https://codereview.chromium.org/1747123002/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/render_int.h:501: void ReleaseBitmap(CFX_DIBitmap*
bitmap) const;
On 2016/03/01 17:38:06, Tom Sepez wrote:
> pBitmap

Done.

https://codereview.chromium.org/1747123002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right):

https://codereview.chromium.org/1747123002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa...
fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:1051: } else {
On 2016/03/01 17:38:06, Tom Sepez wrote:
> else after return not needed.

Done.

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/font/fx_st...
File xfa/src/fgas/src/font/fx_stdfontmgr.h (right):

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/font/fx_st...
xfa/src/fgas/src/font/fx_stdfontmgr.h:109: bool operator>(const
FX_FontDescriptorInfo& x) {
On 2016/03/01 17:38:06, Tom Sepez wrote:
> nit: const methods? e.g.
> 
>   bool operator>(const FX_FontDescriptorInfo& x) const {
> 
> Maybe change |x| to |other|? 

Done.

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.cpp (right):

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.cpp:552: } else {
On 2016/03/01 17:38:06, Tom Sepez wrote:
> else if

Done. Also combined with the inner if().

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.h (right):

https://codereview.chromium.org/1747123002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.h:72: void SetLineBoundary(FX_FLOAT
fLineStart, FX_FLOAT fLineEnd) final;
On 2016/03/01 17:38:06, Tom Sepez wrote:
> So is the issue that override and final are incompatible?  We're usually not
big
> fans of final, might prefer to keep override?

Yea, according to cpplint override final is redundant and it suggests removing
override. I switched to removing final and left the override.

[Tom Sepez, 2016-03-01 19:43:01]

lgtm

[dsinclair, 2016-03-01 19:45:24]

Description was changed from

==========
Fix and enable lint checks.

This CL fixes and enables:
  * readability/namespace
  * readability/multiline_string
  * readability/multiline_comment
  * readability/inheritance
  * readability/function
  * readability/braces
==========

to

==========
Fix and enable lint checks.

This CL fixes and enables:
  * readability/namespace
  * readability/multiline_string
  * readability/multiline_comment
  * readability/inheritance
  * readability/function
  * readability/braces

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/738b08ce6b9f80d93b815411b47c2b11c2f0...
==========

[dsinclair, 2016-03-01 19:45:26]

Committed patchset #3 (id:40001) manually as
738b08ce6b9f80d93b815411b47c2b11c2f090f6 (presubmit successful).