Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: PRESUBMIT.py

Issue 1747123002: Fix and enable lint checks. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | core/include/fpdfapi/fpdf_resource.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for pdfium. 5 """Presubmit script for pdfium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 LINT_FILTERS = [ 11 LINT_FILTERS = [
12 '-build/c++11', 12 '-build/c++11',
13 '-build/include', 13 '-build/include',
14 '-build/include_order', 14 '-build/include_order',
15 '-build/include_what_you_use', 15 '-build/include_what_you_use',
16 '-build/namespaces', 16 '-build/namespaces',
17 '-build/storage_class', 17 '-build/storage_class',
18 '-readability/braces',
19 '-readability/casting', 18 '-readability/casting',
20 '-readability/fn_size', 19 '-readability/fn_size',
21 '-readability/function',
22 '-readability/inheritance',
23 '-readability/multiline_comment',
24 '-readability/multiline_string',
25 '-readability/namespace',
26 '-readability/todo', 20 '-readability/todo',
27 '-readability/utf8', 21 '-readability/utf8',
28 '-runtime/arrays', 22 '-runtime/arrays',
29 '-runtime/casting', 23 '-runtime/casting',
30 '-runtime/explicit', 24 '-runtime/explicit',
31 '-runtime/int', 25 '-runtime/int',
32 '-runtime/printf', 26 '-runtime/printf',
33 '-runtime/references', 27 '-runtime/references',
34 '-runtime/threadsafe_fn', 28 '-runtime/threadsafe_fn',
35 '-whitespace/indent', 29 '-whitespace/indent',
36 '-whitespace/line_length', 30 '-whitespace/line_length',
37 ] 31 ]
38 32
39 def CheckChangeOnUpload(input_api, output_api): 33 def CheckChangeOnUpload(input_api, output_api):
40 results = [] 34 results = []
41 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api) 35 results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api)
42 results += input_api.canned_checks.CheckChangeLintsClean( 36 results += input_api.canned_checks.CheckChangeLintsClean(
43 input_api, output_api, None, LINT_FILTERS) 37 input_api, output_api, None, LINT_FILTERS)
44 return results 38 return results
OLDNEW
« no previous file with comments | « no previous file | core/include/fpdfapi/fpdf_resource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698