xfa/src/fdp/src/css/fde_cssdeclaration.cpp - Issue 1747123002: Fix and enable lint checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fdp/src/css/fde_cssdeclaration.cpp

Issue 1747123002: Fix and enable lint checks. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fdp/src/css/fde_cssdeclaration.cpp

diff --git a/xfa/src/fdp/src/css/fde_cssdeclaration.cpp b/xfa/src/fdp/src/css/fde_cssdeclaration.cpp

index 4eea30c150b94a01de9794ed71cea3c7c8ebcc89..73d0921b154c8e5b69d21b599196756d5b116c25 100644

--- a/xfa/src/fdp/src/css/fde_cssdeclaration.cpp

+++ b/xfa/src/fdp/src/css/fde_cssdeclaration.cpp

@@ -932,11 +932,12 @@ FX_BOOL CFDE_CSSDeclaration::ParseBackgroundProperty(

}

const FDE_CSSCOLORTABLE* pColorItem =

FDE_GetCSSColorByName(pszValue, iValueLen);

- if (pColorItem != NULL)

+ if (pColorItem != NULL) {

if (pColor == NULL) {

pColor = FXTARGET_NewWith(pStaticStore)

CFDE_CSSPrimitiveValue(pColorItem->dwValue);

}

+ }

} break;

case FDE_CSSPRIMITIVETYPE_RGB:

if (pColor == NULL) {

« no previous file with comments | « xfa/src/fdp/src/css/fde_cssdatatable.h ('k') | xfa/src/fdp/src/fde/fde_object.h » ('j') | no next file with comments »