Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 17468003: Use AST's type field and merge types for unary, binary & compare ICs (Closed)

Created:
7 years, 6 months ago by rossberg
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Use AST's type field and merge types for unary, binary & compare ICs R=jkummerow@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=15264

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Split lower & upper bound #

Total comments: 2

Patch Set 4 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -166 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast.h View 1 2 8 chunks +19 lines, -27 lines 0 comments Download
M src/ast.cc View 2 chunks +4 lines, -20 lines 0 comments Download
M src/code-stubs.h View 6 chunks +15 lines, -17 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 8 chunks +22 lines, -28 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 2 chunks +5 lines, -10 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 5 chunks +13 lines, -17 lines 0 comments Download
M src/objects.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/type-info.h View 1 chunk +6 lines, -8 lines 0 comments Download
M src/type-info.cc View 4 chunks +14 lines, -15 lines 0 comments Download
M src/types.cc View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M src/typing.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/typing.cc View 1 2 3 chunks +19 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
7 years, 6 months ago (2013-06-19 15:53:47 UTC) #1
Jakob Kummerow
Maybe<LGTM> :-P https://codereview.chromium.org/17468003/diff/8001/src/types.cc File src/types.cc (right): https://codereview.chromium.org/17468003/diff/8001/src/types.cc#newcode341 src/types.cc:341: return Type::Any(); nit: {} please, and 2-space ...
7 years, 6 months ago (2013-06-20 14:08:55 UTC) #2
rossberg
7 years, 6 months ago (2013-06-21 11:10:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r15264 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698