Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 17468003: Use AST's type field and merge types for unary, binary & compare ICs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comments Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1442 matching lines...) Expand 10 before | Expand all | Expand 10 after
1453 ASSERT(right->representation().IsInteger32()); 1453 ASSERT(right->representation().IsInteger32());
1454 if (instr->HasPowerOf2Divisor()) { 1454 if (instr->HasPowerOf2Divisor()) {
1455 ASSERT(!right->CanBeZero()); 1455 ASSERT(!right->CanBeZero());
1456 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left), 1456 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left),
1457 UseOrConstant(right)); 1457 UseOrConstant(right));
1458 LInstruction* result = DefineAsRegister(mod); 1458 LInstruction* result = DefineAsRegister(mod);
1459 return (left->CanBeNegative() && 1459 return (left->CanBeNegative() &&
1460 instr->CheckFlag(HValue::kBailoutOnMinusZero)) 1460 instr->CheckFlag(HValue::kBailoutOnMinusZero))
1461 ? AssignEnvironment(result) 1461 ? AssignEnvironment(result)
1462 : result; 1462 : result;
1463 } else if (instr->has_fixed_right_arg()) { 1463 } else if (instr->fixed_right_arg().has_value) {
1464 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left), 1464 LModI* mod = new(zone()) LModI(UseRegisterAtStart(left),
1465 UseRegisterAtStart(right)); 1465 UseRegisterAtStart(right));
1466 return AssignEnvironment(DefineAsRegister(mod)); 1466 return AssignEnvironment(DefineAsRegister(mod));
1467 } else if (CpuFeatures::IsSupported(SUDIV)) { 1467 } else if (CpuFeatures::IsSupported(SUDIV)) {
1468 LModI* mod = new(zone()) LModI(UseRegister(left), 1468 LModI* mod = new(zone()) LModI(UseRegister(left),
1469 UseRegister(right)); 1469 UseRegister(right));
1470 LInstruction* result = DefineAsRegister(mod); 1470 LInstruction* result = DefineAsRegister(mod);
1471 return (right->CanBeZero() || 1471 return (right->CanBeZero() ||
1472 (left->RangeCanInclude(kMinInt) && 1472 (left->RangeCanInclude(kMinInt) &&
1473 right->RangeCanInclude(-1) && 1473 right->RangeCanInclude(-1) &&
(...skipping 1185 matching lines...) Expand 10 before | Expand all | Expand 10 after
2659 2659
2660 2660
2661 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2661 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2662 LOperand* object = UseRegister(instr->object()); 2662 LOperand* object = UseRegister(instr->object());
2663 LOperand* index = UseRegister(instr->index()); 2663 LOperand* index = UseRegister(instr->index());
2664 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2664 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2665 } 2665 }
2666 2666
2667 2667
2668 } } // namespace v8::internal 2668 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/lithium-codegen-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698