src/x64/code-stubs-x64.cc - Issue 17468003: Use AST's type field and merge types for unary, binary & compare ICs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 17468003: Use AST's type field and merge types for unary, binary & compare ICs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 8868c7a88adc6c9136d66e29ddce79e837a05ac7..adfc8a1c14bef4b8c531b4878ad8e756de998064 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -1232,7 +1232,7 @@ void BinaryOpStub::GenerateAddStrings(MacroAssembler* masm) {

void BinaryOpStub::GenerateSmiStub(MacroAssembler* masm) {

Label right_arg_changed, call_runtime;

- if (op_ == Token::MOD && has_fixed_right_arg_) {

+ if (op_ == Token::MOD && encoded_right_arg_.has_value) {

// It is guaranteed that the value will fit into a Smi, because if it

// didn't, we wouldn't be here, see BinaryOp_Patch.

__ Cmp(rax, Smi::FromInt(fixed_right_arg_value()));

« no previous file with comments | « src/typing.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »