Chromium Code Reviews
DescriptionRevert of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob. (patchset #2 id:60001 of https://codereview.chromium.org/1738723002/ )
Reason for revert:
The newly added test FetchEvent_ResponseTime is ~33% flaky on Android, see http://crbug.com/590400. The error message is "[FATAL:weak_ptr.cc(20)] Check failed: sequence_checker_.CalledOnValidSequencedThread() || HasOneRef(). WeakPtrs must be invalidated on the same sequenced thread."
BUG=590400
Original issue's description:
> Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob.
>
> Currently response_time is used to identify the response in HttpCache when storing the V8 code cache to HttpCache.
>
> We are planning to support the V8 code caching in CacheStorage.
> To support this, we have to pipe the response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob.
> Design doc: https://docs.google.com/document/d/1dVlgbXls-G65koU2vlmAXy1EVsoY9Z55jaEX7cZgfDA
>
> BUG=581613
>
> Committed: https://crrev.com/3fbfbe6e7690dd2b169cfaaae2ad7ac89537d74b
> Cr-Commit-Position: refs/heads/master@{#377862}
TBR=mkwst@chromium.org,dcheng@chromium.org,junov@chromium.org,nhiroki@chromium.org,horo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=581613
Committed: https://crrev.com/21169106459125eb4c7b4133ce6d33482d865242
Cr-Commit-Position: refs/heads/master@{#378040}
Patch Set 1 #Messages
Total messages: 6 (1 generated)
|