Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1746483002: Revert of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob. (Closed)

Created:
4 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, horo+watch_chromium.org, jam, jkarlin+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob. (patchset #2 id:60001 of https://codereview.chromium.org/1738723002/ ) Reason for revert: The newly added test FetchEvent_ResponseTime is ~33% flaky on Android, see http://crbug.com/590400. The error message is "[FATAL:weak_ptr.cc(20)] Check failed: sequence_checker_.CalledOnValidSequencedThread() || HasOneRef(). WeakPtrs must be invalidated on the same sequenced thread." BUG=590400 Original issue's description: > Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob. > > Currently response_time is used to identify the response in HttpCache when storing the V8 code cache to HttpCache. > > We are planning to support the V8 code caching in CacheStorage. > To support this, we have to pipe the response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob. > Design doc: https://docs.google.com/document/d/1dVlgbXls-G65koU2vlmAXy1EVsoY9Z55jaEX7cZgfDA > > BUG=581613 > > Committed: https://crrev.com/3fbfbe6e7690dd2b169cfaaae2ad7ac89537d74b > Cr-Commit-Position: refs/heads/master@{#377862} TBR=mkwst@chromium.org,dcheng@chromium.org,junov@chromium.org,nhiroki@chromium.org,horo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581613 Committed: https://crrev.com/21169106459125eb4c7b4133ce6d33482d865242 Cr-Commit-Position: refs/heads/master@{#378040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -118 lines) Patch
M content/browser/cache_storage/cache_storage.proto View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_cache.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M content/browser/cache_storage/cache_storage_cache_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_worker/service_worker_types.h View 3 chunks +1 line, -4 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/cache_storage/cache_storage_dispatcher.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
D content/test/data/service_worker/fetch_event_response_via_cache.js View 1 chunk +0 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/Response.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
aelias_OOO_until_Jul13
Created Revert of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob.
4 years, 10 months ago (2016-02-27 00:31:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746483002/1
4 years, 10 months ago (2016-02-27 00:33:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-27 00:44:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/21169106459125eb4c7b4133ce6d33482d865242 Cr-Commit-Position: refs/heads/master@{#378040}
4 years, 10 months ago (2016-02-27 00:46:46 UTC) #5
horo
4 years, 9 months ago (2016-03-01 13:55:34 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1750333002/ by horo@chromium.org.

The reason for reverting is: http://crbug.com/590400 was fixed by
https://codereview.chromium.org/1750513002.

Powered by Google App Engine
This is Rietveld 408576698