content/renderer/cache_storage/cache_storage_dispatcher.cc - Issue 1746483002: Revert of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/cache_storage/cache_storage_dispatcher.cc

Issue 1746483002: Revert of Pipe response_time from FetchManager to CacheStorage and ServiceWorkerURLRequestJob. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_types.cc ('k') | content/renderer/service_worker/service_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/cache_storage/cache_storage_dispatcher.cc

diff --git a/content/renderer/cache_storage/cache_storage_dispatcher.cc b/content/renderer/cache_storage/cache_storage_dispatcher.cc

index b20d19eef385616c07c76395e915a49f151c3a8b..90914688593c128f39b4950184d3c4356f5b9d0f 100644

--- a/content/renderer/cache_storage/cache_storage_dispatcher.cc

+++ b/content/renderer/cache_storage/cache_storage_dispatcher.cc

@@ -89,8 +89,7 @@

web_response.responseType(), headers,

base::UTF16ToASCII(base::StringPiece16(web_response.blobUUID())),

web_response.blobSize(), web_response.streamURL(),

- blink::WebServiceWorkerResponseErrorUnknown,

- base::Time::FromInternalValue(web_response.responseTime()));

+ blink::WebServiceWorkerResponseErrorUnknown);

}

CacheStorageCacheQueryParams QueryParamsFromWebQueryParams(

@@ -647,7 +646,6 @@

web_response->setStatus(response.status_code);

web_response->setStatusText(base::ASCIIToUTF16(response.status_text));

web_response->setResponseType(response.response_type);

- web_response->setResponseTime(response.response_time.ToInternalValue());

for (const auto& i : response.headers) {

web_response->setHeader(base::ASCIIToUTF16(i.first),