Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) happened while resetting |fetch_dispatcher_| in ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad7ac89537d74b/content/browser/service_worker/service_worker_browsertest.cc#458

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400
Committed: https://crrev.com/d028982479f6173a0a20c274cd8bac2852fefaf6
Cr-Commit-Position: refs/heads/master@{#378421}

[horo, 2016-02-29 09:22:33]

Description was changed from

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) were happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676
==========

to

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) were happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400
==========

[horo, 2016-02-29 09:22:55]

horo@chromium.org changed reviewers:
+ nhiroki@chromium.org

[horo, 2016-02-29 09:22:56]

nhiroki@
Could you please review this?

[horo, 2016-02-29 09:57:43]

Description was changed from

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) were happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400
==========

to

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400
==========

[nhiroki, 2016-03-01 05:58:15]

lgtm

https://codereview.chromium.org/1750513002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/1750513002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:647: const
scoped_refptr<ServiceWorkerVersion>& worker) {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

[horo, 2016-03-01 07:02:23]

Thank you

https://codereview.chromium.org/1750513002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/1750513002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_browsertest.cc:647: const
scoped_refptr<ServiceWorkerVersion>& worker) {
On 2016/03/01 05:58:15, nhiroki wrote:
> ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));

Done.

[horo, 2016-03-01 07:02:31]

The CQ bit was checked by horo@chromium.org

[horo, 2016-03-01 07:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1750513002/#ps20001
(title: "ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::IO));")

[commit-bot: I haz the power, 2016-03-01 07:02:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750513002/20001

[commit-bot: I haz the power, 2016-03-01 09:46:30]

Description was changed from

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400
==========

to

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400
==========

[commit-bot: I haz the power, 2016-03-01 09:46:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-01 09:47:52]

Description was changed from

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400
==========

to

==========
Reset fetch_dispatcher_ in ServiceWorkerVersionBrowserTest on IO thread.

The crashes (issue 590400) happened while resetting |fetch_dispatcher_| in
ServiceWorkerVersionBrowserTest::FetchOnRegisteredWorker().
https://chromium.googlesource.com/chromium/src/+/3fbfbe6e7690dd2b169cfaaae2ad...

|fetch_dispatcher_| is created on IO thread.
So it must be cleared on IO thread.

BUG=590676, 590400

Committed: https://crrev.com/d028982479f6173a0a20c274cd8bac2852fefaf6
Cr-Commit-Position: refs/heads/master@{#378421}
==========

[commit-bot: I haz the power, 2016-03-01 09:47:53]

Patchset 2 (id:??) landed as
https://crrev.com/d028982479f6173a0a20c274cd8bac2852fefaf6
Cr-Commit-Position: refs/heads/master@{#378421}