Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1746393003: [DevTools] Postpone more agents instantiation until attached. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Postpone more agents instantiation until attached. To support multiple attached devtools, we have to instantiate individual agents on demand, rather than on creation. This patch moves most of agents, with only worker and inspector to go. BUG=590878 Committed: https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 Cr-Commit-Position: refs/heads/master@{#378509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -70 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 4 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp View 4 chunks +3 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 8 chunks +43 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-01 00:55:46 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746393003/1
4 years, 9 months ago (2016-03-01 01:46:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 05:19:35 UTC) #6
pfeldman
lgtm
4 years, 9 months ago (2016-03-01 18:49:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1746393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1746393003/1
4 years, 9 months ago (2016-03-01 19:00:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 19:16:34 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b547858514737d59af3c55b2b06b4e511624c304 Cr-Commit-Position: refs/heads/master@{#378509}
4 years, 9 months ago (2016-03-01 19:18:06 UTC) #12
dgozman
4 years, 9 months ago (2016-03-03 19:25:54 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1761663003/ by dgozman@chromium.org.

The reason for reverting is: Speculative revert to fix performance regressions:
https://bugs.chromium.org/p/chromium/issues/detail?id=591406.

Powered by Google App Engine
This is Rietveld 408576698