Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

Issue 1746393003: [DevTools] Postpone more agents instantiation until attached. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 29 matching lines...) Expand all
40 class ConsoleMessage; 40 class ConsoleMessage;
41 class ConsoleMessageStorage; 41 class ConsoleMessageStorage;
42 class InspectedFrames; 42 class InspectedFrames;
43 class InspectorDOMAgent; 43 class InspectorDOMAgent;
44 class WorkerInspectorProxy; 44 class WorkerInspectorProxy;
45 class WorkerGlobalScopeProxy; 45 class WorkerGlobalScopeProxy;
46 46
47 class CORE_EXPORT PageConsoleAgent final : public InspectorConsoleAgent { 47 class CORE_EXPORT PageConsoleAgent final : public InspectorConsoleAgent {
48 WTF_MAKE_NONCOPYABLE(PageConsoleAgent); 48 WTF_MAKE_NONCOPYABLE(PageConsoleAgent);
49 public: 49 public:
50 static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(V8RuntimeAgent* runti meAgent, InspectorDOMAgent* domAgent, InspectedFrames* inspectedFrames) 50 static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(V8RuntimeAgent* runti meAgent, V8DebuggerAgent* debuggerAgent, InspectorDOMAgent* domAgent, InspectedF rames* inspectedFrames)
51 { 51 {
52 return adoptPtrWillBeNoop(new PageConsoleAgent(runtimeAgent, domAgent, i nspectedFrames)); 52 return adoptPtrWillBeNoop(new PageConsoleAgent(runtimeAgent, debuggerAge nt, domAgent, inspectedFrames));
53 } 53 }
54 ~PageConsoleAgent() override; 54 ~PageConsoleAgent() override;
55 DECLARE_VIRTUAL_TRACE(); 55 DECLARE_VIRTUAL_TRACE();
56 56
57 void enable(ErrorString*) override; 57 void enable(ErrorString*) override;
58 void disable(ErrorString*) override; 58 void disable(ErrorString*) override;
59 59
60 void workerTerminated(WorkerInspectorProxy*); 60 void workerTerminated(WorkerInspectorProxy*);
61 61
62 void workerConsoleAgentEnabled(WorkerGlobalScopeProxy*); 62 void workerConsoleAgentEnabled(WorkerGlobalScopeProxy*);
63 63
64 protected: 64 protected:
65 ConsoleMessageStorage* messageStorage() override; 65 ConsoleMessageStorage* messageStorage() override;
66 66
67 void enableStackCapturingIfNeeded() override; 67 void enableStackCapturingIfNeeded() override;
68 void disableStackCapturingIfNeeded() override; 68 void disableStackCapturingIfNeeded() override;
69 69
70 private: 70 private:
71 PageConsoleAgent(V8RuntimeAgent*, InspectorDOMAgent*, InspectedFrames*); 71 PageConsoleAgent(V8RuntimeAgent*, V8DebuggerAgent*, InspectorDOMAgent*, Insp ectedFrames*);
72 void clearMessages(ErrorString*) override; 72 void clearMessages(ErrorString*) override;
73 73
74 RawPtrWillBeMember<InspectorDOMAgent> m_inspectorDOMAgent; 74 RawPtrWillBeMember<InspectorDOMAgent> m_inspectorDOMAgent;
75 RawPtrWillBeMember<InspectedFrames> m_inspectedFrames; 75 RawPtrWillBeMember<InspectedFrames> m_inspectedFrames;
76 HashSet<WorkerGlobalScopeProxy*> m_workersWithEnabledConsole; 76 HashSet<WorkerGlobalScopeProxy*> m_workersWithEnabledConsole;
77 77
78 static int s_enabledAgentCount; 78 static int s_enabledAgentCount;
79 }; 79 };
80 80
81 } // namespace blink 81 } // namespace blink
82 82
83 83
84 #endif // !defined(PageConsoleAgent_h) 84 #endif // !defined(PageConsoleAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698