Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/WebKit/Source/core/inspector/PageConsoleAgent.h

Issue 1746393003: [DevTools] Postpone more agents instantiation until attached. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h b/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
index 2d863a90719338ce2c7e9c2aafca3bbc97f39bba..2a736a7bb96da8a77ca08dbb85bd343ac6cf6dc7 100644
--- a/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
+++ b/third_party/WebKit/Source/core/inspector/PageConsoleAgent.h
@@ -47,9 +47,9 @@ class WorkerGlobalScopeProxy;
class CORE_EXPORT PageConsoleAgent final : public InspectorConsoleAgent {
WTF_MAKE_NONCOPYABLE(PageConsoleAgent);
public:
- static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(V8RuntimeAgent* runtimeAgent, InspectorDOMAgent* domAgent, InspectedFrames* inspectedFrames)
+ static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(V8RuntimeAgent* runtimeAgent, V8DebuggerAgent* debuggerAgent, InspectorDOMAgent* domAgent, InspectedFrames* inspectedFrames)
{
- return adoptPtrWillBeNoop(new PageConsoleAgent(runtimeAgent, domAgent, inspectedFrames));
+ return adoptPtrWillBeNoop(new PageConsoleAgent(runtimeAgent, debuggerAgent, domAgent, inspectedFrames));
}
~PageConsoleAgent() override;
DECLARE_VIRTUAL_TRACE();
@@ -68,7 +68,7 @@ protected:
void disableStackCapturingIfNeeded() override;
private:
- PageConsoleAgent(V8RuntimeAgent*, InspectorDOMAgent*, InspectedFrames*);
+ PageConsoleAgent(V8RuntimeAgent*, V8DebuggerAgent*, InspectorDOMAgent*, InspectedFrames*);
void clearMessages(ErrorString*) override;
RawPtrWillBeMember<InspectorDOMAgent> m_inspectorDOMAgent;

Powered by Google App Engine
This is Rietveld 408576698