Rename enums/functions that collide in chromium style in platform/

Rename enums/functions that collide in chromium style in platform/

R=esprehn@chromium.org, pdr
BUG=582312
Committed: https://crrev.com/c5117b4cc2638739551a9eeedf5b10e177e2368b
Cr-Commit-Position: refs/heads/master@{#378619}

[danakj, 2016-02-29 22:17:09]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 22:17:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746283002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746283002/1

[Raymond Toy, 2016-02-29 22:28:28]

rtoy@chromium.org changed reviewers:
+ rtoy@chromium.org

[Raymond Toy, 2016-02-29 22:28:29]

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/Panner.h (left):

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/Panner.h:60: PanningModel
panningModel() const { return m_panningModel; }
DBYC:  Does panningModel() conflict?  If not, then I don't think it should be
removed in this CL.

[danakj, 2016-02-29 22:35:32]

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/audio/Panner.h (left):

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/audio/Panner.h:60: PanningModel
panningModel() const { return m_panningModel; }
On 2016/02/29 22:28:29, Raymond Toy wrote:
> DBYC:  Does panningModel() conflict?  If not, then I don't think it should be
> removed in this CL.

Yep. PanningModel PanningModel() is ambiguous.

[danakj, 2016-02-29 22:35:52]

danakj@chromium.org changed reviewers:
+ haraken@chromium.org

[danakj, 2016-02-29 22:35:53]

+haraken for modules/

[jbroman, 2016-02-29 22:40:20]

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/FontDescription.h (right):

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/FontDescription.h:164: VariantLigatures
variantLigatures() const;
drive-by: won't VariantLigatures have the same issue?

[danakj, 2016-02-29 22:42:06]

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/FontDescription.h (right):

https://codereview.chromium.org/1746283002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/FontDescription.h:164: VariantLigatures
variantLigatures() const;
On 2016/02/29 22:40:20, jbroman wrote:
> drive-by: won't VariantLigatures have the same issue?

You would think so, my regex didn't find it. Hm. Guess I'll have to make another
pass.. (this patch is probably big enough for now though)

[commit-bot: I haz the power, 2016-02-29 22:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 22:46:45]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[danakj, 2016-02-29 22:50:38]

Patchset #2 (id:20001) has been deleted

[danakj, 2016-02-29 22:51:58]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 22:52:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746283002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746283002/40001

[commit-bot: I haz the power, 2016-02-29 23:13:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-29 23:13:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[haraken, 2016-02-29 23:15:27]

LGTM

[urvang, 2016-02-29 23:54:03]

urvang@chromium.org changed reviewers:
+ urvang@chromium.org

[urvang, 2016-02-29 23:54:04]

lgtm

LGTM for WEBPImageDecoder*

[chrishtr, 2016-03-01 01:07:30]

chrishtr@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2016-03-01 01:07:30]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-03-01 01:07:32]

lgtm

[chrishtr, 2016-03-01 01:07:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, urvang@chromium.org
Link to the patchset: https://codereview.chromium.org/1746283002/#ps60001
(title: "get-names-13-platform: .")

[commit-bot: I haz the power, 2016-03-01 01:08:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746283002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746283002/60001

[commit-bot: I haz the power, 2016-03-01 03:51:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 03:51:49]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-03-01 18:42:31]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-01 18:43:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746283002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746283002/60001

[commit-bot: I haz the power, 2016-03-01 18:51:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 18:51:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-03-01 20:58:42]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-01 20:58:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, urvang@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1746283002/#ps80001
(title: "get-names-13-platform: .")

[commit-bot: I haz the power, 2016-03-01 20:59:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746283002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746283002/80001

[danakj, 2016-03-01 21:02:30]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-03-01 21:02:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, urvang@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1746283002/#ps100001
(title: "get-names-13-platform: .")

[commit-bot: I haz the power, 2016-03-01 21:04:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746283002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746283002/100001

[commit-bot: I haz the power, 2016-03-01 22:47:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 22:47:42]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-03-01 23:07:50]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-03-01 23:08:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746283002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746283002/100001

[commit-bot: I haz the power, 2016-03-02 00:12:32]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-03-02 00:13:43]

Description was changed from

==========
Rename enums/functions that collide in chromium style in platform/

R=esprehn@chromium.org, pdr
BUG=582312
==========

to

==========
Rename enums/functions that collide in chromium style in platform/

R=esprehn@chromium.org, pdr
BUG=582312

Committed: https://crrev.com/c5117b4cc2638739551a9eeedf5b10e177e2368b
Cr-Commit-Position: refs/heads/master@{#378619}
==========

[commit-bot: I haz the power, 2016-03-02 00:13:46]

Patchset 5 (id:??) landed as
https://crrev.com/c5117b4cc2638739551a9eeedf5b10e177e2368b
Cr-Commit-Position: refs/heads/master@{#378619}