third_party/WebKit/Source/build/scripts/make_style_builder.py - Issue 1746283002: Rename enums/functions that collide in chromium style in platform/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_style_builder.py

Issue 1746283002: Rename enums/functions that collide in chromium style in platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: get-names-13-platform: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/build/scripts/make_style_builder.py

diff --git a/third_party/WebKit/Source/build/scripts/make_style_builder.py b/third_party/WebKit/Source/build/scripts/make_style_builder.py

index 4015dda879e3e525d5cc5d2c546e97da687bd67d..1e81ac22acf7db0d2b39a5a5f17cc5d9548695c5 100755

--- a/third_party/WebKit/Source/build/scripts/make_style_builder.py

+++ b/third_party/WebKit/Source/build/scripts/make_style_builder.py

@@ -55,8 +55,9 @@ class StyleBuilderWriter(css_properties.CSSProperties):

upper_camel = property['upper_camel_name']

set_if_none(property, 'name_for_methods', upper_camel.replace('Webkit', ''))

name = property['name_for_methods']

+ simple_type_name = str(property['type_name']).split('::')[-1]

set_if_none(property, 'type_name', 'E' + name)

- set_if_none(property, 'getter', lower_first(name) if property['type_name'] != name else 'get' + name)

+ set_if_none(property, 'getter', lower_first(name) if simple_type_name != name else 'get' + name)

set_if_none(property, 'setter', 'set' + name)

set_if_none(property, 'initial', 'initial' + name)

if property['custom_all']:

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp » ('j') | no next file with comments »