Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

Issue 1746283002: Rename enums/functions that collide in chromium style in platform/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get-names-13-platform: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
index bf46ddc90833f8c0fe7fa1b33465bbf42a2a3daf..c346fffd546adfbb06fbc3bc9458a051d0b7c7e5 100644
--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
@@ -126,7 +126,7 @@ bool GIFImageDecoder::haveDecodedRow(size_t frameIndex, GIFRow::const_iterator r
// Initialize the frame if necessary.
ImageFrame& buffer = m_frameBufferCache[frameIndex];
- if ((buffer.status() == ImageFrame::FrameEmpty) && !initFrameBuffer(frameIndex))
+ if ((buffer.getStatus() == ImageFrame::FrameEmpty) && !initFrameBuffer(frameIndex))
return false;
const size_t transparentPixel = frameContext->transparentPixel();
@@ -183,7 +183,7 @@ bool GIFImageDecoder::frameComplete(size_t frameIndex)
// Initialize the frame if necessary. Some GIFs insert do-nothing frames,
// in which case we never reach haveDecodedRow() before getting here.
ImageFrame& buffer = m_frameBufferCache[frameIndex];
- if ((buffer.status() == ImageFrame::FrameEmpty) && !initFrameBuffer(frameIndex))
+ if ((buffer.getStatus() == ImageFrame::FrameEmpty) && !initFrameBuffer(frameIndex))
return false; // initFrameBuffer() has already called setFailed().
buffer.setStatus(ImageFrame::FrameComplete);
@@ -200,7 +200,7 @@ bool GIFImageDecoder::frameComplete(size_t frameIndex)
// true, we check the start state of the frame -- if it doesn't have
// alpha, we're safe.
const ImageFrame* prevBuffer = &m_frameBufferCache[buffer.requiredPreviousFrameIndex()];
- ASSERT(prevBuffer->disposalMethod() != ImageFrame::DisposeOverwritePrevious);
+ ASSERT(prevBuffer->getDisposalMethod() != ImageFrame::DisposeOverwritePrevious);
// Now, if we're at a DisposeNotSpecified or DisposeKeep frame, then
// we can say we have no alpha if that frame had no alpha. But
@@ -210,7 +210,7 @@ bool GIFImageDecoder::frameComplete(size_t frameIndex)
// The only remaining case is a DisposeOverwriteBgcolor frame. If
// it had no alpha, and its rect is contained in the current frame's
// rect, we know the current frame has no alpha.
- if ((prevBuffer->disposalMethod() == ImageFrame::DisposeOverwriteBgcolor) && !prevBuffer->hasAlpha() && buffer.originalFrameRect().contains(prevBuffer->originalFrameRect()))
+ if ((prevBuffer->getDisposalMethod() == ImageFrame::DisposeOverwriteBgcolor) && !prevBuffer->hasAlpha() && buffer.originalFrameRect().contains(prevBuffer->originalFrameRect()))
buffer.setHasAlpha(false);
}
}
@@ -234,7 +234,7 @@ size_t GIFImageDecoder::clearCacheExceptFrame(size_t clearExceptFrame)
size_t clearExceptFrame2 = kNotFound;
if (clearExceptFrame < m_frameBufferCache.size()) {
const ImageFrame& frame = m_frameBufferCache[clearExceptFrame];
- if ((frame.status() != ImageFrame::FrameEmpty) && (frame.disposalMethod() == ImageFrame::DisposeOverwritePrevious)) {
+ if ((frame.getStatus() != ImageFrame::FrameEmpty) && (frame.getDisposalMethod() == ImageFrame::DisposeOverwritePrevious)) {
clearExceptFrame2 = clearExceptFrame;
clearExceptFrame = frame.requiredPreviousFrameIndex();
}
@@ -246,7 +246,7 @@ size_t GIFImageDecoder::clearCacheExceptFrame(size_t clearExceptFrame)
// the required previous frames until we find the nearest non-empty
// ancestor. Preserving that will minimize the amount of future decoding
// needed.
- while ((clearExceptFrame < m_frameBufferCache.size()) && (m_frameBufferCache[clearExceptFrame].status() == ImageFrame::FrameEmpty))
+ while ((clearExceptFrame < m_frameBufferCache.size()) && (m_frameBufferCache[clearExceptFrame].getStatus() == ImageFrame::FrameEmpty))
clearExceptFrame = m_frameBufferCache[clearExceptFrame].requiredPreviousFrameIndex();
return clearCacheExceptTwoFrames(clearExceptFrame, clearExceptFrame2);
}
@@ -256,7 +256,7 @@ size_t GIFImageDecoder::clearCacheExceptTwoFrames(size_t clearExceptFrame1, size
{
size_t frameBytesCleared = 0;
for (size_t i = 0; i < m_frameBufferCache.size(); ++i) {
- if (m_frameBufferCache[i].status() != ImageFrame::FrameEmpty && i != clearExceptFrame1 && i != clearExceptFrame2) {
+ if (m_frameBufferCache[i].getStatus() != ImageFrame::FrameEmpty && i != clearExceptFrame1 && i != clearExceptFrame2) {
frameBytesCleared += frameBytesAtIndex(i);
clearFrameBuffer(i);
}
@@ -266,7 +266,7 @@ size_t GIFImageDecoder::clearCacheExceptTwoFrames(size_t clearExceptFrame1, size
void GIFImageDecoder::clearFrameBuffer(size_t frameIndex)
{
- if (m_reader && m_frameBufferCache[frameIndex].status() == ImageFrame::FramePartial) {
+ if (m_reader && m_frameBufferCache[frameIndex].getStatus() == ImageFrame::FramePartial) {
// Reset the state of the partial frame in the reader so that the frame
// can be decoded again when requested.
m_reader->clearDecodeState(frameIndex);
@@ -290,7 +290,7 @@ void GIFImageDecoder::initializeNewFrame(size_t index)
const GIFFrameContext* frameContext = m_reader->frameContext(index);
buffer->setOriginalFrameRect(intersection(frameContext->frameRect(), IntRect(IntPoint(), size())));
buffer->setDuration(frameContext->delayTime());
- buffer->setDisposalMethod(frameContext->disposalMethod());
+ buffer->setDisposalMethod(frameContext->getDisposalMethod());
buffer->setRequiredPreviousFrameIndex(findRequiredPreviousFrame(index, false));
}
@@ -306,7 +306,7 @@ void GIFImageDecoder::decode(size_t index)
do {
framesToDecode.append(frameToDecode);
frameToDecode = m_frameBufferCache[frameToDecode].requiredPreviousFrameIndex();
- } while (frameToDecode != kNotFound && m_frameBufferCache[frameToDecode].status() != ImageFrame::FrameComplete);
+ } while (frameToDecode != kNotFound && m_frameBufferCache[frameToDecode].getStatus() != ImageFrame::FrameComplete);
for (auto i = framesToDecode.rbegin(); i != framesToDecode.rend(); ++i) {
if (!m_reader->decode(*i)) {
@@ -315,7 +315,7 @@ void GIFImageDecoder::decode(size_t index)
}
// We need more data to continue decoding.
- if (m_frameBufferCache[*i].status() != ImageFrame::FrameComplete)
+ if (m_frameBufferCache[*i].getStatus() != ImageFrame::FrameComplete)
break;
}
@@ -351,13 +351,13 @@ bool GIFImageDecoder::initFrameBuffer(size_t frameIndex)
return setFailed();
} else {
const ImageFrame* prevBuffer = &m_frameBufferCache[requiredPreviousFrameIndex];
- ASSERT(prevBuffer->status() == ImageFrame::FrameComplete);
+ ASSERT(prevBuffer->getStatus() == ImageFrame::FrameComplete);
// Preserve the last frame as the starting state for this frame.
if (!buffer->copyBitmapData(*prevBuffer))
return setFailed();
- if (prevBuffer->disposalMethod() == ImageFrame::DisposeOverwriteBgcolor) {
+ if (prevBuffer->getDisposalMethod() == ImageFrame::DisposeOverwriteBgcolor) {
// We want to clear the previous frame to transparent, without
// affecting pixels in the image outside of the frame.
const IntRect& prevRect = prevBuffer->originalFrameRect();

Powered by Google App Engine
This is Rietveld 408576698