|
|
Created:
6 years, 10 months ago by steve3 Modified:
6 years, 8 months ago CC:
skia-review_googlegroups.com Base URL:
http://skia.googlecode.com/svn/trunk/ Visibility:
Public. |
DescriptionAdd more big endian platforms
This patch adds more platforms to the list that have the BIGENDIAN defines set.
Downstream users are using parts of SKIA on BigEndian machines.
Patch Set 1 : #Patch Set 2 : #Messages
Total messages: 37 (0 generated)
lgtm
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/30001
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 174603002-30001 failed and returned exit status 1. Running presubmit commit checks ... ** Presubmit ERRORS ** The email steve@ssinger.info is not in Skia's AUTHORS file. Issue owner, this CL must include an addition to the Skia AUTHORS file. Googler reviewers, please check that the AUTHORS entry corresponds to an email address in http://goto/cla-signers. If it does not then ask the issue owner to sign the CLA at https://developers.google.com/open-source/cla/individual (individual) or https://developers.google.com/open-source/cla/corporate (corporate). Presubmit checks took 4.4s to calculate.
https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig.h File include/core/SkPreConfig.h (right): https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig... include/core/SkPreConfig.h:101: (defined(__sh__) && defined(__LITTLE_ENDIAN__)) || \ Is this correct? Shouldn't this be like (defined(__sh__) && defined(__BIG_ENDIAN__)) || \ or is the SuperH arch just backward?
On 2014/03/11 20:09:01, bungeman1 wrote: > https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig.h > File include/core/SkPreConfig.h (right): > > https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig... > include/core/SkPreConfig.h:101: (defined(__sh__) && defined(__LITTLE_ENDIAN__)) > || \ > Is this correct? Shouldn't this be like > > (defined(__sh__) && defined(__BIG_ENDIAN__)) || \ > > or is the SuperH arch just backward? I think your right, this should be __BIG_ENDIAN__ Patch updated
The CQ bit was checked by steve@ssinger.info
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/50001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for AUTHORS: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file AUTHORS Hunk #1 FAILED at 17. 1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej Patch: AUTHORS Index: AUTHORS =================================================================== --- AUTHORS (revision 13508) +++ AUTHORS (working copy) @@ -17,5 +17,6 @@ Google Inc. <*@google.com> Intel <*@intel.com> NVIDIA <*@nvidia.com> +Steve Singer <steve@ssinger.info> The Chromium Authors <*@chromium.org> Thiago Fransosi Farina <thiago.farina@gmail.com>
I think I've addressed the issue bungeman1 raised. Is there any anything else I need to do to get this committed? I am a bit new to the process but I filled out a Contributor License Agreement a while back.
The CQ bit was checked by steve@ssinger.info
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001
The CQ bit was unchecked by cmp@chromium.org
The CQ bit was checked by cmp@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001
The CQ bit was unchecked by sergeyberezin@chromium.org
On 2014/03/24 20:27:51, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://skia-tree-status.appspot.com/cq/steve%40ssinger.info/174603002/70001 Something is wrong with the CQ or the try server on this CL - the try server is refusing to run the jobs, and CQ is confused about the response. We are looking into the problem. In the meantime you may want to commit manually, or try creating a new CL with the base URL starting with 'https:' (not just 'http:').
The CQ bit was checked by bungeman@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001
The CQ bit was unchecked by mtklein@google.com
The CQ bit was checked by mtklein@google.com
The CQ bit was unchecked by rmistry@google.com
The CQ bit was checked by rmistry@google.com
The CQ bit was unchecked by rmistry@google.com
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001
The CQ bit was unchecked by cmp@chromium.org
The CQ bit was checked by cmp@chromium.org
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001
On 2014/03/26 00:00:07, Sergey Berezin wrote: > On 2014/03/24 20:27:51, I haz the power (commit-bot) wrote: > > CQ is trying da patch. Follow status at > > https://skia-tree-status.appspot.com/cq/steve%40ssinger.info/174603002/70001 > > Something is wrong with the CQ or the try server on this CL - the try server is > refusing to run the jobs, and CQ is confused about the response. We are looking > into the problem. > > In the meantime you may want to commit manually, or try creating a new CL with > the base URL starting with 'https:' (not just 'http:'). I have created a new issue with the same patch after getting a new svn repo with https. https://codereview.chromium.org/218733002 Can someone LGTM that issue and see if it has the same problem?
On 2014/03/30 21:06:48, steve3 wrote: > On 2014/03/26 00:00:07, Sergey Berezin wrote: > > On 2014/03/24 20:27:51, I haz the power (commit-bot) wrote: > > > CQ is trying da patch. Follow status at > > > https://skia-tree-status.appspot.com/cq/steve%40ssinger.info/174603002/70001 > > > > Something is wrong with the CQ or the try server on this CL - the try server > is > > refusing to run the jobs, and CQ is confused about the response. We are > looking > > into the problem. > > > > In the meantime you may want to commit manually, or try creating a new CL with > > the base URL starting with 'https:' (not just 'http:'). > > I have created a new issue with the same patch after getting a new svn repo with > https. > > https://codereview.chromium.org/218733002 > > Can someone LGTM that issue and see if it has the same problem? You'll need a Skia project committer to lgtm it. Maybe TBR is an option, too?
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
Message was sent while issue was closed.
Closing because of issue with the CQ on this review. This was later committed under https://codereview.chromium.org/218733002/ . |