Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 218733002: Add more big endian platforms (Closed)

Created:
6 years, 8 months ago by steve3
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add more big endian platforms This patch adds more platforms to the list that have the BIGENDIAN defines set. Downstream users are using parts of SKIA on BigEndian machines. Committed: http://code.google.com/p/skia/source/detail?r=14046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
steve3
The CQ bit was checked by steve@ssinger.info
6 years, 8 months ago (2014-03-30 21:03:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/218733002/1
6 years, 8 months ago (2014-03-30 21:03:58 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 21:03:58 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-03-30 21:03:58 UTC) #4
cmp
lgtm
6 years, 8 months ago (2014-03-30 21:26:20 UTC) #5
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 21:26:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/218733002/1
6 years, 8 months ago (2014-03-30 21:26:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-30 21:26:28 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-03-30 21:26:29 UTC) #9
bungeman-skia
lgtm
6 years, 8 months ago (2014-03-31 14:11:50 UTC) #10
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 8 months ago (2014-03-31 14:11:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/218733002/1
6 years, 8 months ago (2014-03-31 14:12:06 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 14:12:13 UTC) #13
commit-bot: I haz the power
Presubmit check for 218733002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 8 months ago (2014-03-31 14:12:13 UTC) #14
bungeman-skia
looking for an API lgtm
6 years, 8 months ago (2014-04-01 14:34:35 UTC) #15
bsalomon
lgtm
6 years, 8 months ago (2014-04-01 14:40:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/218733002/1
6 years, 8 months ago (2014-04-01 14:40:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/218733002/1
6 years, 8 months ago (2014-04-01 21:33:31 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/218733002/1
6 years, 8 months ago (2014-04-01 21:53:03 UTC) #19
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 8 months ago (2014-04-03 15:39:54 UTC) #20
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 8 months ago (2014-04-03 15:41:32 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/steve@ssinger.info/218733002/1
6 years, 8 months ago (2014-04-03 15:41:42 UTC) #22
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 16:38:08 UTC) #23
Message was sent while issue was closed.
Change committed as 14046

Powered by Google App Engine
This is Rietveld 408576698