Add more big endian platforms

Add more big endian platforms

This patch adds more platforms to the list that have the BIGENDIAN defines set.

Downstream users are using parts of SKIA on BigEndian machines.

[reed1, 2014-03-11 19:28:31]

lgtm

[commit-bot: I haz the power, 2014-03-11 19:28:39]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/30001

[commit-bot: I haz the power, 2014-03-11 19:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 19:29:01]

Presubmit check for 174603002-30001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
The email steve@ssinger.info is not in Skia's AUTHORS file.
Issue owner, this CL must include an addition to the Skia AUTHORS file.
Googler reviewers, please check that the AUTHORS entry corresponds to an email
address in http://goto/cla-signers. If it does not then ask the issue owner to
sign the CLA at https://developers.google.com/open-source/cla/individual
(individual) or https://developers.google.com/open-source/cla/corporate
(corporate).

Presubmit checks took 4.4s to calculate.

[bungeman-skia, 2014-03-11 20:09:01]

https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig.h
File include/core/SkPreConfig.h (right):

https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig...
include/core/SkPreConfig.h:101: (defined(__sh__) && defined(__LITTLE_ENDIAN__))
|| \
Is this correct? Shouldn't this be like

(defined(__sh__) && defined(__BIG_ENDIAN__)) || \

or is the SuperH arch just backward?

[steve3, 2014-03-12 03:17:03]

On 2014/03/11 20:09:01, bungeman1 wrote:
>
https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig.h
> File include/core/SkPreConfig.h (right):
> 
>
https://codereview.chromium.org/174603002/diff/30001/include/core/SkPreConfig...
> include/core/SkPreConfig.h:101: (defined(__sh__) &&
defined(__LITTLE_ENDIAN__))
> || \
> Is this correct? Shouldn't this be like
> 
> (defined(__sh__) && defined(__BIG_ENDIAN__)) || \
> 
> or is the SuperH arch just backward?

I think your right, this should be __BIG_ENDIAN__ 
Patch updated

[steve3, 2014-03-23 02:02:59]

The CQ bit was checked by steve@ssinger.info

[commit-bot: I haz the power, 2014-03-23 02:03:04]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/50001

[commit-bot: I haz the power, 2014-03-23 02:03:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-23 02:03:08]

Failed to apply patch for AUTHORS:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 17.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
===================================================================
--- AUTHORS	(revision 13508)
+++ AUTHORS	(working copy)
@@ -17,5 +17,6 @@
 Google Inc. <*@google.com>
 Intel <*@intel.com>
 NVIDIA <*@nvidia.com>
+Steve Singer <steve@ssinger.info>
 The Chromium Authors <*@chromium.org>
 Thiago Fransosi Farina <thiago.farina@gmail.com>

[steve3, 2014-03-23 02:09:37]

I think I've addressed the issue bungeman1 raised.
Is there any anything else I need to do to get this 
committed?

I am a bit new to the process but I filled out a  Contributor License Agreement
a while back.

[steve3, 2014-03-23 02:21:21]

The CQ bit was checked by steve@ssinger.info

[commit-bot: I haz the power, 2014-03-23 02:21:24]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001

[cmp, 2014-03-24 20:24:55]

The CQ bit was unchecked by cmp@chromium.org

[cmp, 2014-03-24 20:27:42]

The CQ bit was checked by cmp@chromium.org

[commit-bot: I haz the power, 2014-03-24 20:27:51]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001

[Sergey Berezin, 2014-03-25 23:57:43]

The CQ bit was unchecked by sergeyberezin@chromium.org

[Sergey Berezin, 2014-03-26 00:00:07]

On 2014/03/24 20:27:51, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://skia-tree-status.appspot.com/cq/steve%40ssinger.info/174603002/70001

Something is wrong with the CQ or the try server on this CL - the try server is
refusing to run the jobs, and CQ is confused about the response. We are looking
into the problem. 

In the meantime you may want to commit manually, or try creating a new CL with
the base URL starting with 'https:' (not just 'http:').

[bungeman-skia, 2014-03-26 21:09:57]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-03-26 21:10:38]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001

[mtklein, 2014-03-27 18:25:29]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-03-27 18:25:29]

The CQ bit was checked by mtklein@google.com

[rmistry, 2014-03-28 12:15:50]

The CQ bit was unchecked by rmistry@google.com

[rmistry, 2014-03-28 12:15:58]

The CQ bit was checked by rmistry@google.com

[rmistry, 2014-03-28 12:21:10]

The CQ bit was unchecked by rmistry@google.com

[rmistry, 2014-03-28 12:22:16]

The CQ bit was checked by rmistry@google.com

[commit-bot: I haz the power, 2014-03-28 12:22:21]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001

[cmp, 2014-03-30 16:51:43]

The CQ bit was unchecked by cmp@chromium.org

[cmp, 2014-03-30 16:55:34]

The CQ bit was checked by cmp@chromium.org

[commit-bot: I haz the power, 2014-03-30 16:55:40]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001

[steve3, 2014-03-30 21:06:48]

On 2014/03/26 00:00:07, Sergey Berezin wrote:
> On 2014/03/24 20:27:51, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://skia-tree-status.appspot.com/cq/steve%40ssinger.info/174603002/70001
> 
> Something is wrong with the CQ or the try server on this CL - the try server
is
> refusing to run the jobs, and CQ is confused about the response. We are
looking
> into the problem. 
> 
> In the meantime you may want to commit manually, or try creating a new CL with
> the base URL starting with 'https:' (not just 'http:').

I have created a new issue with the same patch after getting a new svn repo with
https.

https://codereview.chromium.org/218733002

Can someone LGTM that issue and see if it has the same problem?

[cmp, 2014-03-30 21:27:12]

On 2014/03/30 21:06:48, steve3 wrote:
> On 2014/03/26 00:00:07, Sergey Berezin wrote:
> > On 2014/03/24 20:27:51, I haz the power (commit-bot) wrote:
> > > CQ is trying da patch. Follow status at
> > >
https://skia-tree-status.appspot.com/cq/steve%40ssinger.info/174603002/70001
> > 
> > Something is wrong with the CQ or the try server on this CL - the try server
> is
> > refusing to run the jobs, and CQ is confused about the response. We are
> looking
> > into the problem. 
> > 
> > In the meantime you may want to commit manually, or try creating a new CL
with
> > the base URL starting with 'https:' (not just 'http:').
> 
> I have created a new issue with the same patch after getting a new svn repo
with
> https.
> 
> https://codereview.chromium.org/218733002
> 
> Can someone LGTM that issue and see if it has the same problem?

You'll need a Skia project committer to lgtm it.  Maybe TBR is an option, too?

[commit-bot: I haz the power, 2014-04-01 21:32:44]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001

[commit-bot: I haz the power, 2014-04-01 21:52:11]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/steve@ssinger.info/174603002/70001

[commit-bot: I haz the power, 2014-04-03 14:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 14:26:46]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[bungeman-skia, 2014-04-11 15:43:28]

Closing because of issue with the CQ on this review. This was later committed
under https://codereview.chromium.org/218733002/ .