Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745963002: CREDENTIAL: Do type checks for credential constructors. (Closed)

Created:
4 years, 9 months ago by Mike West
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CREDENTIAL: Do type checks for credential constructors. BUG=590610 R=jochen@chromium.org Committed: https://crrev.com/80aa06df6c68611a18eff99fc6a048d6843b9ea6 Cr-Commit-Position: refs/heads/master@{#378194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike West
Mind taking a look, Jochen?
4 years, 9 months ago (2016-02-29 09:59:58 UTC) #1
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-02-29 10:08:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745963002/1
4 years, 9 months ago (2016-02-29 10:24:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 11:25:06 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 11:26:33 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/80aa06df6c68611a18eff99fc6a048d6843b9ea6
Cr-Commit-Position: refs/heads/master@{#378194}

Powered by Google App Engine
This is Rietveld 408576698