CREDENTIAL: Do type checks for credential constructors.

third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/credentialmanager/PasswordCredential.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/dom/URLSearchParams.h"
 #include "core/html/FormData.h"
 #include "modules/credentialmanager/FormDataOptions.h"
 #include "modules/credentialmanager/PasswordCredentialData.h"
 #include "platform/credentialmanager/PlatformPasswordCredential.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/WebCredential.h"
 #include "public/platform/WebPasswordCredential.h"
 
 namespace blink {
 
 PasswordCredential* PasswordCredential::create(WebPasswordCredential* webPasswordCredential)
 {
     return new PasswordCredential(webPasswordCredential);
 }
 
 PasswordCredential* PasswordCredential::create(const PasswordCredentialData& data, ExceptionState& exceptionState)
 {
+    if (data.id().isEmpty()) {
+        exceptionState.throwTypeError("'id' must not be empty.");
+        return nullptr;
+    }
+    if (data.password().isEmpty()) {
+        exceptionState.throwTypeError("'password' must not be empty.");
+        return nullptr;
+    }
+
     KURL iconURL = parseStringAsURL(data.iconURL(), exceptionState);
     if (exceptionState.hadException())
         return nullptr;
+
     return new PasswordCredential(data.id(), data.password(), data.name(), iconURL);
 }
 
 PasswordCredential::PasswordCredential(WebPasswordCredential* webPasswordCredential)
     : Credential(webPasswordCredential->platformCredential())
     , m_idName("username")
     , m_passwordName("password")
 {
 }
 
@@ skipping 51 matching lines @@
     return static_cast<PlatformPasswordCredential*>(m_platformCredential.get())->password();
 }
 
 DEFINE_TRACE(PasswordCredential)
 {
     Credential::trace(visitor);
     visitor->trace(m_additionalData);
 }
 
 } // namespace blink