Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html

Issue 1745963002: CREDENTIAL: Do type checks for credential constructors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
index 9183351fde4ff633affba5838f1a83e979e5c57b..3a02a114ae8a0ed39fef7ebf8a5c0f0f3f0e3334 100644
--- a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html
@@ -91,4 +91,25 @@ test(function() {
});
});
}, 'Construct a FederatedCredential with an invalid federation URL.');
+
+test(function() {
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential(); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({}); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({ 'id': undefined }); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({ 'id': '' }); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({ 'provider': undefined }); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({ 'provider': '' }); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({ 'id': undefined, 'provider': undefined }); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({ 'id': undefined, 'provider': '' }); });
+ assert_throws(new TypeError(),
+ () => { new FederatedCredential({ 'id': undefined, 'provider': undefined }); });
+}, 'FederatedCredential objects require IDs and Providers');
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698