Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174533005: Reapply "Avoid use of empty string as a property name." (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Avoid use of empty string as a property name." This reapplies https://codereview.chromium.org//170103003 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=32893

Patch Set 1 #

Total comments: 2

Patch Set 2 : First round of fixes. #

Patch Set 3 : Another fix. #

Messages

Total messages: 4 (0 generated)
kasperl
https://codereview.chromium.org/174533005/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart File sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/174533005/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart#newcode1236 sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:1236: => new ClassBuilder()); This needs to get the namer ...
6 years, 10 months ago (2014-02-21 10:42:43 UTC) #1
floitsch
Still running some tests, but the previously failing tests seem to work now. https://codereview.chromium.org/174533005/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart File ...
6 years, 10 months ago (2014-02-21 12:11:15 UTC) #2
kasperl
LGTM.
6 years, 10 months ago (2014-02-21 12:13:51 UTC) #3
floitsch
6 years, 10 months ago (2014-02-21 12:46:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r32893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698