Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 170103003: Avoid use of empty string as a property name. (Closed)

Created:
6 years, 10 months ago by sra1
Modified:
6 years, 10 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Avoid use of empty string as a property name. Empty strings as property names can tickle V8 bugs. R=floitsch@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=32884

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
sra1
I decided against a shared library since JS_GET_NAME is an existing mechanism that potentially allows ...
6 years, 10 months ago (2014-02-20 21:41:30 UTC) #1
karlklose
LGTM.
6 years, 10 months ago (2014-02-21 09:17:41 UTC) #2
floitsch
LGTM.
6 years, 10 months ago (2014-02-21 09:53:51 UTC) #3
floitsch
Committed patchset #1 manually as r32884 (presubmit successful).
6 years, 10 months ago (2014-02-21 10:03:40 UTC) #4
floitsch
I committed this CL for Stephen. Maybe we can get this one into 1.2.
6 years, 10 months ago (2014-02-21 10:04:53 UTC) #5
floitsch
6 years, 10 months ago (2014-02-21 10:38:59 UTC) #6
Message was sent while issue was closed.
Reverted and continued in
https://codereview.chromium.org/174533005

Powered by Google App Engine
This is Rietveld 408576698