sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart - Issue 174533005: Reapply "Avoid use of empty string as a property name."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

Issue 174533005: Reapply "Avoid use of empty string as a property name." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Another fix. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

index bc13d80766871923a784705637033c41ed0776f6..db83cfe973ba9ac5a0529c0ec7ee821a4ed9ce2e 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

@@ -224,7 +224,7 @@ String getReflectionDataParser(String classesCollector,

var globalObject = data[3];

var descriptor = data[4];

var isRoot = !!data[5];

- var fields = descriptor && descriptor[""];

+ var fields = descriptor && descriptor["${namer.classDescriptorProperty}"];

var classes = [];

var functions = [];

''';

@@ -233,7 +233,7 @@ String getReflectionDataParser(String classesCollector,

function processStatics(descriptor) {

for (var property in descriptor) {

if (!hasOwnProperty.call(descriptor, property)) continue;

- if (property === "") continue;

+ if (property === "${namer.classDescriptorProperty}") continue;

var element = descriptor[property];

var firstChar = property.substring(0, 1);

var previousProperty;

@@ -286,7 +286,8 @@ String getReflectionDataParser(String classesCollector,

optionalMethods[prop] = previousProp;

} else {

var elem = element[prop];

- if (prop && elem != null &&''' // Break long line.

+ if (prop !== "${namer.classDescriptorProperty}" &&'''

+ ''' elem != null &&''' // Break long line.

''' elem.constructor === Array &&''' // Break long line.

''' prop !== "<>") {

addStubs(newDesc, elem, prop, false, element, []);