Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Side by Side Diff: net/quic/quic_spdy_stream.h

Issue 1745303003: Remove virtual keyword from QuicSpdyStream::WriteTrailers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115455799
Patch Set: Revert to Patch Set 1 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The base class for streams which deliver data to/from an application. 5 // The base class for streams which deliver data to/from an application.
6 // In each direction, the data on such a stream first contains compressed 6 // In each direction, the data on such a stream first contains compressed
7 // headers then body data. 7 // headers then body data.
8 8
9 #ifndef NET_QUIC_QUIC_SPDY_STREAM_H_ 9 #ifndef NET_QUIC_QUIC_SPDY_STREAM_H_
10 #define NET_QUIC_QUIC_SPDY_STREAM_H_ 10 #define NET_QUIC_QUIC_SPDY_STREAM_H_
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 void OnStreamReset(const QuicRstStreamFrame& frame) override; 100 void OnStreamReset(const QuicRstStreamFrame& frame) override;
101 101
102 // Writes the headers contained in |header_block| to the dedicated 102 // Writes the headers contained in |header_block| to the dedicated
103 // headers stream. 103 // headers stream.
104 virtual size_t WriteHeaders(const SpdyHeaderBlock& header_block, 104 virtual size_t WriteHeaders(const SpdyHeaderBlock& header_block,
105 bool fin, 105 bool fin,
106 QuicAckListenerInterface* ack_notifier_delegate); 106 QuicAckListenerInterface* ack_notifier_delegate);
107 107
108 // Writes the trailers contained in |trailer_block| to the dedicated 108 // Writes the trailers contained in |trailer_block| to the dedicated
109 // headers stream. Trailers will always have the FIN set. 109 // headers stream. Trailers will always have the FIN set.
110 virtual size_t WriteTrailers(SpdyHeaderBlock trailer_block, 110 size_t WriteTrailers(SpdyHeaderBlock trailer_block,
111 QuicAckListenerInterface* ack_notifier_delegate); 111 QuicAckListenerInterface* ack_notifier_delegate);
112 112
113 // Marks |bytes_consumed| of the headers data as consumed. 113 // Marks |bytes_consumed| of the headers data as consumed.
114 void MarkHeadersConsumed(size_t bytes_consumed); 114 void MarkHeadersConsumed(size_t bytes_consumed);
115 115
116 // Marks |bytes_consumed| of the trailers data as consumed. 116 // Marks |bytes_consumed| of the trailers data as consumed.
117 void MarkTrailersConsumed(size_t bytes_consumed); 117 void MarkTrailersConsumed(size_t bytes_consumed);
118 118
119 // This block of functions wraps the sequencer's functions of the same 119 // This block of functions wraps the sequencer's functions of the same
120 // name. These methods return uncompressed data until that has 120 // name. These methods return uncompressed data until that has
121 // been fully processed. Then they simply delegate to the sequencer. 121 // been fully processed. Then they simply delegate to the sequencer.
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 // TODO(rtenneti): Temporary until crbug.com/585591 is solved. 196 // TODO(rtenneti): Temporary until crbug.com/585591 is solved.
197 Liveness liveness_ = ALIVE; 197 Liveness liveness_ = ALIVE;
198 bool read_in_progress_ = false; 198 bool read_in_progress_ = false;
199 199
200 DISALLOW_COPY_AND_ASSIGN(QuicSpdyStream); 200 DISALLOW_COPY_AND_ASSIGN(QuicSpdyStream);
201 }; 201 };
202 202
203 } // namespace net 203 } // namespace net
204 204
205 #endif // NET_QUIC_QUIC_SPDY_STREAM_H_ 205 #endif // NET_QUIC_QUIC_SPDY_STREAM_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698