Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1745243002: Pass rect by const reference in SetClip_Rect(). (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : LTBR. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -84 lines) Patch
M core/include/fxge/fx_ge.h View 3 chunks +6 lines, -26 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M core/src/fxge/ge/fx_ge_device.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 1 3 chunks +9 lines, -18 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_gedevice.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_graphics.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-02-29 21:09:07 UTC) #2
dsinclair
https://codereview.chromium.org/1745243002/diff/1/fpdfsdk/src/fxedit/fxet_pageobjs.cpp File fpdfsdk/src/fxedit/fxet_pageobjs.cpp (right): https://codereview.chromium.org/1745243002/diff/1/fpdfsdk/src/fxedit/fxet_pageobjs.cpp#newcode296 fpdfsdk/src/fxedit/fxet_pageobjs.cpp:296: pDevice->SetClip_Rect(FX_RECT((int32_t)rcTemp.left, (int32_t)rcTemp.right, This should be left, top, right bottom? ...
4 years, 9 months ago (2016-02-29 21:15:26 UTC) #3
Tom Sepez
PS2. https://codereview.chromium.org/1745243002/diff/1/fpdfsdk/src/fxedit/fxet_pageobjs.cpp File fpdfsdk/src/fxedit/fxet_pageobjs.cpp (right): https://codereview.chromium.org/1745243002/diff/1/fpdfsdk/src/fxedit/fxet_pageobjs.cpp#newcode296 fpdfsdk/src/fxedit/fxet_pageobjs.cpp:296: pDevice->SetClip_Rect(FX_RECT((int32_t)rcTemp.left, (int32_t)rcTemp.right, On 2016/02/29 21:15:26, dsinclair wrote: > ...
4 years, 9 months ago (2016-02-29 21:17:45 UTC) #4
dsinclair
lgtm
4 years, 9 months ago (2016-02-29 21:18:32 UTC) #5
Tom Sepez
4 years, 9 months ago (2016-02-29 21:23:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bec4ea1e64b8049c572dd088c9c09a94f49b2353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698