fpdfsdk/src/fpdfformfill.cpp - Issue 1745243002: Pass rect by const reference in SetClip_Rect().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfformfill.cpp

Issue 1745243002: Pass rect by const reference in SetClip_Rect(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: LTBR. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfformfill.cpp

diff --git a/fpdfsdk/src/fpdfformfill.cpp b/fpdfsdk/src/fpdfformfill.cpp

index a14c66fbc6f9ddb2f657d67854336f6043512f6e..c2e75c34d572d3855c64d5d09861b4c662ddfd33 100644

--- a/fpdfsdk/src/fpdfformfill.cpp

+++ b/fpdfsdk/src/fpdfformfill.cpp

@@ -332,11 +332,7 @@ DLLEXPORT void STDCALL FPDF_FFLDraw(FPDF_FORMHANDLE hHandle,

CFX_Matrix matrix;

pPage->GetDisplayMatrix(matrix, start_x, start_y, size_x, size_y, rotate);

- FX_RECT clip;

- clip.left = start_x;

- clip.right = start_x + size_x;

- clip.top = start_y;

- clip.bottom = start_y + size_y;

+ FX_RECT clip(start_x, start_y, start_x + size_x, start_y + size_y);

#ifdef _SKIA_SUPPORT_

std::unique_ptr<CFX_SkiaDevice> pDevice(new CFX_SkiaDevice);

@@ -345,7 +341,7 @@ DLLEXPORT void STDCALL FPDF_FFLDraw(FPDF_FORMHANDLE hHandle,

#endif

pDevice->Attach((CFX_DIBitmap*)bitmap);

pDevice->SaveState();

- pDevice->SetClip_Rect(&clip);

+ pDevice->SetClip_Rect(clip);

#ifndef PDF_ENABLE_XFA

if (CPDFSDK_PageView* pPageView = FormHandleToPageView(hHandle, pPage))

« no previous file with comments | « core/src/fxge/ge/fx_ge_device.cpp ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »