Pass rect by const reference in SetClip_Rect().

fpdfsdk/src/pdfwindow/PWL_ListCtrl.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/include/pdfwindow/PWL_ListCtrl.h"
 #include "fpdfsdk/include/pdfwindow/PWL_Wnd.h"
 
 CPWL_ListCtrl::CPWL_ListCtrl()
@@ skipping 123 matching lines @@
 void CPWL_ListCtrl::RePosChildWnd() {
   ResetFace();
 }
 
 void CPWL_ListCtrl::DrawChildAppearance(CFX_RenderDevice* pDevice,
                                         CFX_Matrix* pUser2Device) {
   pDevice->SaveState();
   CFX_FloatRect rcClient = GetClientRect();
   CFX_FloatRect rcTemp = rcClient;
   pUser2Device->TransformRect(rcTemp);
-  FX_RECT rcClip((int32_t)rcTemp.left, (int32_t)rcTemp.bottom,
-                 (int32_t)rcTemp.right, (int32_t)rcTemp.top);
-
-  pDevice->SetClip_Rect(&rcClip);
+  pDevice->SetClip_Rect(FX_RECT((int32_t)rcTemp.left, (int32_t)rcTemp.bottom,

[dsinclair, 2016/02/29 21:15:26]

This is ... upside down?

[Tom Sepez, 2016/02/29 21:17:45]

Has been since day 1 ...

9d8ec5a6 (Nico Weber        2015-08-04 13:00:21 -0700 144)   FX_RECT
rcClip((int32_t)rcTemp.left, (int32_t)rcTemp.bottom,
9d8ec5a6 (Nico Weber        2015-08-04 13:00:21 -0700 145)                 
(int32_t)rcTemp.right, (int32_t)rcTemp.top);

+                                (int32_t)rcTemp.right, (int32_t)rcTemp.top));
 
   for (int32_t i = 0, sz = m_aChildren.GetSize(); i < sz; i++) {
     if (CPWL_Wnd* pChild = m_aChildren.GetAt(i)) {
       CFX_FloatRect rcChild = pChild->ChildToParent(pChild->GetWindowRect());
       if (!(rcChild.top < rcClient.bottom || rcChild.bottom > rcClient.top)) {
         CFX_Matrix mt = pChild->GetChildMatrix();
         if (mt.IsIdentity()) {
           pChild->DrawAppearance(pDevice, pUser2Device);
         } else {
           mt.Concat(*pUser2Device);
@@ skipping 39 matching lines @@
 }
 
 CFX_FloatRect CPWL_ListCtrl::OutToIn(const CFX_FloatRect& rect) const {
   CFX_FloatRect rcClient = GetClientRect();
 
   return CFX_FloatRect(rect.left - rcClient.left + m_ptScroll.x,
                        rect.bottom - rcClient.top + m_ptScroll.y,
                        rect.right - rcClient.left + m_ptScroll.x,
                        rect.top - rcClient.top + m_ptScroll.y);
 }