Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/parser/CSSPropertyParser.cpp

Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 8a1a6428c0099c4056ac1fe5ad1c26c682dcacfe..6c051a9d6b239fddda38b79c2f75d0514f9c3184 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -1066,6 +1066,26 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)
             return false;
         }
         break;
+    case CSSPropertyNavDown: // auto | <id> targetframe | inherit
+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        if (id == CSSValueAuto) {
+            validPrimitive = true;
+        } else if (num == 1 && (value->unit == CSSPrimitiveValue::CSS_STRING || value->unit == CSSPrimitiveValue::CSS_PARSER_HEXCOLOR)) {

[fs, 2014/04/14 12:32:01]

This would accept "foo" (a literal string) as well. Maybe a CSS_PARSER_IDSEL
type is required.

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+            value->unit = CSSPrimitiveValue::CSS_STRING;

[fs, 2014/04/14 12:32:01]

Probably better to avoid mutating |value| and just create the (string)value up
front.

[Krzysztof Olczyk, 2014/04/17 13:48:40]

This is basically what CSS_PARSER_* primitive values are for - to be later
mutated to correct type.
We can't resolve, at syntax parsing, whether it's IDSEL or HEXCOLOR. We need a
context to determine that.
#deadbeaf will denote the hex number of color in background-color property, but
will denote <div id="deadbeaf"> element in nav-up property.

[fs, 2014/04/17 15:33:48]

Sure, it's needed for disambiguation, but that doesn't mean it by necessity
should turn into a string - hopefully this point is mute though with other
changes.

+            validPrimitive = true;
+        } else if (num == 2) {
+            RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();

[fs, 2014/04/14 12:32:01]

...WillBeRawPtr

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+            while (value) {
+                list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));

[fs, 2014/04/14 12:32:01]

This looks a bit lenient.

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+                value = m_valueList->next();
+            }
+            parsedValue = list.release();
+        } else {
+            return false;
+        }
+        break;
     case CSSPropertyFlex: {
         ShorthandScope scope(this, propId);
         if (id == CSSValueNone) {