Source/core/frame/UseCounter.cpp - Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 17450016: Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased once again to master, fixed layout test. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | Source/core/page/EventHandler.cpp » ('j') | Source/core/page/FocusController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/UseCounter.cpp

diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp

index 468874d673aa4d83614e7d6fa904015d99d4ebf7..37775641fab189e8f6e8d735cd4f715e2756972d 100644

--- a/Source/core/frame/UseCounter.cpp

+++ b/Source/core/frame/UseCounter.cpp

@@ -507,6 +507,10 @@ int UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(int id)

case CSSPropertyPerspectiveOrigin: return 450;

case CSSPropertyBackfaceVisibility: return 451;

case CSSPropertyGridTemplate: return 452;

+ case CSSPropertyNavDown: return 453;

+ case CSSPropertyNavLeft: return 454;

+ case CSSPropertyNavRight: return 456;

fs 2014/04/14 12:32:01 Why leave out 455?

Krzysztof Olczyk 2014/04/17 13:48:40 Done.

+ case CSSPropertyNavUp: return 457;

// Add new features above this line (don't change the assigned numbers of the existing

// items) and update maximumCSSSampleId() with the new maximum value.

@@ -526,7 +530,7 @@ int UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(int id)

return 0;

}

-static int maximumCSSSampleId() { return 451; }

+static int maximumCSSSampleId() { return 457; }

void UseCounter::muteForInspector()

{