Implementation of CSS3 nav-up/down/left/right properties from CSS3 UI.

Source/core/css/parser/CSSPropertyParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 1048 matching lines @@
             validPrimitive = true;
         else {
             RefPtrWillBeRawPtr<CSSValue> val = parseFilter();
             if (val) {
                 addProperty(propId, val, important);
                 return true;
             }
             return false;
         }
         break;
+    case CSSPropertyNavDown: // auto | <id> targetframe | inherit
+    case CSSPropertyNavLeft:
+    case CSSPropertyNavRight:
+    case CSSPropertyNavUp:
+        if (id == CSSValueAuto) {
+            validPrimitive = true;
+        } else if (num == 1 && (value->unit == CSSPrimitiveValue::CSS_STRING || value->unit == CSSPrimitiveValue::CSS_PARSER_HEXCOLOR)) {

[fs, 2014/04/14 12:32:01]

This would accept "foo" (a literal string) as well. Maybe a CSS_PARSER_IDSEL
type is required.

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+            value->unit = CSSPrimitiveValue::CSS_STRING;

[fs, 2014/04/14 12:32:01]

Probably better to avoid mutating |value| and just create the (string)value up
front.

[Krzysztof Olczyk, 2014/04/17 13:48:40]

This is basically what CSS_PARSER_* primitive values are for - to be later
mutated to correct type.
We can't resolve, at syntax parsing, whether it's IDSEL or HEXCOLOR. We need a
context to determine that.
#deadbeaf will denote the hex number of color in background-color property, but
will denote <div id="deadbeaf"> element in nav-up property.

[fs, 2014/04/17 15:33:48]

Sure, it's needed for disambiguation, but that doesn't mean it by necessity
should turn into a string - hopefully this point is mute though with other
changes.

+            validPrimitive = true;
+        } else if (num == 2) {
+            RefPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();

[fs, 2014/04/14 12:32:01]

...WillBeRawPtr

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+            while (value) {
+                list->append(cssValuePool().createValue(value->string, CSSPrimitiveValue::CSS_STRING));

[fs, 2014/04/14 12:32:01]

This looks a bit lenient.

[Krzysztof Olczyk, 2014/04/17 13:48:40]

Done.

+                value = m_valueList->next();
+            }
+            parsedValue = list.release();
+        } else {
+            return false;
+        }
+        break;
     case CSSPropertyFlex: {
         ShorthandScope scope(this, propId);
         if (id == CSSValueNone) {
             addProperty(CSSPropertyFlexGrow, cssValuePool().createValue(0, CSSPrimitiveValue::CSS_NUMBER), important);
             addProperty(CSSPropertyFlexShrink, cssValuePool().createValue(0, CSSPrimitiveValue::CSS_NUMBER), important);
             addProperty(CSSPropertyFlexBasis, cssValuePool().createIdentifierValue(CSSValueAuto), important);
             return true;
         }
         return parseFlex(m_valueList.get(), important);
     }
@@ skipping 7376 matching lines @@
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueFill));
     if (!seenStroke)
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueStroke));
     if (!seenMarkers)
         parsedValues->append(CSSPrimitiveValue::createIdentifier(CSSValueMarkers));
 
     return parsedValues.release();
 }
 
 } // namespace WebCore