third_party/WebKit/Source/core/workers/SharedWorker.cpp - Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/SharedWorker.cpp

Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/SharedWorker.cpp

diff --git a/third_party/WebKit/Source/core/workers/SharedWorker.cpp b/third_party/WebKit/Source/core/workers/SharedWorker.cpp

index 3f089e8cbc22cd445a50267f680f91e65bcf9fa7..dbbd0dbb67fe7f0602050f9b4621ae0c88d92717 100644

--- a/third_party/WebKit/Source/core/workers/SharedWorker.cpp

+++ b/third_party/WebKit/Source/core/workers/SharedWorker.cpp

@@ -67,8 +67,6 @@ SharedWorker* SharedWorker::create(ExecutionContext* context, const String& url,

OwnPtr<WebMessagePortChannel> remotePort = channel->port2()->disentangle();

ASSERT(remotePort);

- worker->suspendIfNeeded();

// We don't currently support nested workers, so workers can only be created from documents.

Document* document = toDocument(context);

if (!document->securityOrigin()->canAccessSharedWorkers()) {