third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp - Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/InProcessWorkerBase.h ('k') | third_party/WebKit/Source/core/workers/SharedWorker.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp b/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

index 7fc496960bebaa06b2fff17c0e1f9429162ae43d..202ef70ace3dffe1cbffb7e78f0aefe9aa132c5c 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp

@@ -44,8 +44,6 @@ void InProcessWorkerBase::postMessage(ExecutionContext* context, PassRefPtr<Seri

bool InProcessWorkerBase::initialize(ExecutionContext* context, const String& url, ExceptionState& exceptionState)

{

- suspendIfNeeded();

KURL scriptURL = resolveURL(url, exceptionState);

if (scriptURL.isEmpty())

return false;

@@ -69,7 +67,7 @@ void InProcessWorkerBase::terminate()

m_contextProxy->terminateWorkerGlobalScope();

}

-void InProcessWorkerBase::stop()

+void InProcessWorkerBase::contextDestroyed()

{

terminate();

}