third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h - Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

Issue 1744973002: Make AbstractWorker a ContextLifecycleObserver rather than an ActiveDOMObject (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/SharedWorker.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

index ee1325fddca1f91f9d248ddf9de501de814df3f4..1cb45bff0cd2227d29cec5fd8cad98f87cb070f8 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

@@ -75,13 +75,11 @@ private:

static ServiceWorker* getOrCreate(ExecutionContext*, PassOwnPtr<WebServiceWorker::Handle>);

ServiceWorker(ExecutionContext*, PassOwnPtr<WebServiceWorker::Handle>);

- // ActiveDOMObject overrides.

+ // Inherit from ContextLifecycleObserver.

bool hasPendingActivity() const override;

- void stop() override;

// A handle to the service worker representation in the embedder.

OwnPtr<WebServiceWorker::Handle> m_handle;

- bool m_wasStopped;

};

} // namespace blink