Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1744673002: Added support for multiple sink observers per frame. (Closed)

Created:
4 years, 9 months ago by btolsch
Modified:
4 years, 9 months ago
Reviewers:
mark a. foltz, imcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, media-router+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added support for multiple sink observers per frame. PresentationServiceDelegate was incorrectly storing only the most recent listener that was added per frame. This also adds a tests for this case. BUG=589706 R=imcheng@chromium.org,mfoltz@chromium.org Committed: https://crrev.com/fc8d378ad2b8f61081cc74ddef519023aab79a2c Cr-Commit-Position: refs/heads/master@{#378095}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed url nit and SmallMap TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -10 lines) Patch
M chrome/browser/media/router/presentation_service_delegate_impl.cc View 1 5 chunks +16 lines, -10 lines 0 comments Download
M chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
btolsch
Here is my patch for supporting multiple sink observers per frame in PresentationServiceDelegateImpl. PTAL.
4 years, 9 months ago (2016-02-26 22:29:43 UTC) #3
mark a. foltz
LGTM, nice patch https://codereview.chromium.org/1744673002/diff/1/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc File chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc (right): https://codereview.chromium.org/1744673002/diff/1/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc#newcode198 chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc:198: std::string presentation_url1("http://url1.fakeUrl"); Nit: Please use a ...
4 years, 9 months ago (2016-02-27 00:28:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1744673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1744673002/20001
4 years, 9 months ago (2016-02-27 01:57:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-27 02:56:36 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-02-27 02:59:36 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fc8d378ad2b8f61081cc74ddef519023aab79a2c
Cr-Commit-Position: refs/heads/master@{#378095}

Powered by Google App Engine
This is Rietveld 408576698