Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/media/router/presentation_service_delegate_impl.cc

Issue 1744673002: Added support for multiple sink observers per frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed url nit and SmallMap TODO Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h" 5 #include "chrome/browser/media/router/presentation_service_delegate_impl.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
100 100
101 void set_delegate_observer(DelegateObserver* observer) { 101 void set_delegate_observer(DelegateObserver* observer) {
102 delegate_observer_ = observer; 102 delegate_observer_ = observer;
103 } 103 }
104 104
105 private: 105 private:
106 MediaSource GetMediaSourceFromListener( 106 MediaSource GetMediaSourceFromListener(
107 content::PresentationScreenAvailabilityListener* listener) const; 107 content::PresentationScreenAvailabilityListener* listener) const;
108 base::SmallMap<std::map<std::string, MediaRoute::Id>> 108 base::SmallMap<std::map<std::string, MediaRoute::Id>>
109 presentation_id_to_route_id_; 109 presentation_id_to_route_id_;
110 scoped_ptr<PresentationMediaSinksObserver> sinks_observer_; 110 // TODO(btolsch): Use SmallMap here if move operation patch is accepted.
111 std::map<std::string, scoped_ptr<PresentationMediaSinksObserver>>
112 url_to_sinks_observer_;
111 base::ScopedPtrHashMap<MediaRoute::Id, 113 base::ScopedPtrHashMap<MediaRoute::Id,
112 scoped_ptr<PresentationConnectionStateSubscription>> 114 scoped_ptr<PresentationConnectionStateSubscription>>
113 connection_state_subscriptions_; 115 connection_state_subscriptions_;
114 ScopedVector<PresentationSessionMessagesObserver> session_messages_observers_; 116 ScopedVector<PresentationSessionMessagesObserver> session_messages_observers_;
115 117
116 // References to the owning WebContents, and the corresponding MediaRouter. 118 // References to the owning WebContents, and the corresponding MediaRouter.
117 const content::WebContents* web_contents_; 119 const content::WebContents* web_contents_;
118 MediaRouter* router_; 120 MediaRouter* router_;
119 121
120 DelegateObserver* delegate_observer_; 122 DelegateObserver* delegate_observer_;
(...skipping 30 matching lines...) Expand all
151 153
152 const std::vector<MediaRoute::Id> PresentationFrame::GetRouteIds() const { 154 const std::vector<MediaRoute::Id> PresentationFrame::GetRouteIds() const {
153 std::vector<MediaRoute::Id> route_ids; 155 std::vector<MediaRoute::Id> route_ids;
154 for (const auto& e : presentation_id_to_route_id_) 156 for (const auto& e : presentation_id_to_route_id_)
155 route_ids.push_back(e.second); 157 route_ids.push_back(e.second);
156 return route_ids; 158 return route_ids;
157 } 159 }
158 160
159 bool PresentationFrame::SetScreenAvailabilityListener( 161 bool PresentationFrame::SetScreenAvailabilityListener(
160 content::PresentationScreenAvailabilityListener* listener) { 162 content::PresentationScreenAvailabilityListener* listener) {
161 if (sinks_observer_ && sinks_observer_->listener() == listener) 163 MediaSource source(GetMediaSourceFromListener(listener));
164 auto& sinks_observer = url_to_sinks_observer_[source.id()];
165 if (sinks_observer && sinks_observer->listener() == listener)
162 return false; 166 return false;
163 167
164 MediaSource source(GetMediaSourceFromListener(listener)); 168 sinks_observer.reset(
165 sinks_observer_.reset(
166 new PresentationMediaSinksObserver(router_, listener, source)); 169 new PresentationMediaSinksObserver(router_, listener, source));
167 170
168 if (!sinks_observer_->Init()) { 171 if (!sinks_observer->Init()) {
169 sinks_observer_.reset(); 172 url_to_sinks_observer_.erase(source.id());
170 listener->OnScreenAvailabilityNotSupported(); 173 listener->OnScreenAvailabilityNotSupported();
171 return false; 174 return false;
172 } 175 }
173 176
174 return true; 177 return true;
175 } 178 }
176 179
177 bool PresentationFrame::RemoveScreenAvailabilityListener( 180 bool PresentationFrame::RemoveScreenAvailabilityListener(
178 content::PresentationScreenAvailabilityListener* listener) { 181 content::PresentationScreenAvailabilityListener* listener) {
179 if (sinks_observer_ && sinks_observer_->listener() == listener) { 182 MediaSource source(GetMediaSourceFromListener(listener));
180 sinks_observer_.reset(); 183 auto sinks_observer_it = url_to_sinks_observer_.find(source.id());
184 if (sinks_observer_it != url_to_sinks_observer_.end() &&
185 sinks_observer_it->second->listener() == listener) {
186 url_to_sinks_observer_.erase(sinks_observer_it);
181 return true; 187 return true;
182 } 188 }
183 return false; 189 return false;
184 } 190 }
185 191
186 bool PresentationFrame::HasScreenAvailabilityListenerForTest( 192 bool PresentationFrame::HasScreenAvailabilityListenerForTest(
187 const MediaSource::Id& source_id) const { 193 const MediaSource::Id& source_id) const {
188 return sinks_observer_ && sinks_observer_->source().id() == source_id; 194 return url_to_sinks_observer_.find(source_id) != url_to_sinks_observer_.end();
189 } 195 }
190 196
191 void PresentationFrame::Reset() { 197 void PresentationFrame::Reset() {
192 for (const auto& pid_route_id : presentation_id_to_route_id_) 198 for (const auto& pid_route_id : presentation_id_to_route_id_)
193 router_->DetachRoute(pid_route_id.second); 199 router_->DetachRoute(pid_route_id.second);
194 200
195 presentation_id_to_route_id_.clear(); 201 presentation_id_to_route_id_.clear();
196 sinks_observer_.reset(); 202 url_to_sinks_observer_.clear();
197 connection_state_subscriptions_.clear(); 203 connection_state_subscriptions_.clear();
198 session_messages_observers_.clear(); 204 session_messages_observers_.clear();
199 } 205 }
200 206
201 void PresentationFrame::RemoveConnection(const std::string& presentation_id, 207 void PresentationFrame::RemoveConnection(const std::string& presentation_id,
202 const MediaRoute::Id& route_id) { 208 const MediaRoute::Id& route_id) {
203 // Remove the presentation id mapping so a later call to Reset is a no-op. 209 // Remove the presentation id mapping so a later call to Reset is a no-op.
204 presentation_id_to_route_id_.erase(presentation_id); 210 presentation_id_to_route_id_.erase(presentation_id);
205 211
206 // We no longer need to observe route messages. 212 // We no longer need to observe route messages.
(...skipping 668 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 bool PresentationServiceDelegateImpl::HasScreenAvailabilityListenerForTest( 881 bool PresentationServiceDelegateImpl::HasScreenAvailabilityListenerForTest(
876 int render_process_id, 882 int render_process_id,
877 int render_frame_id, 883 int render_frame_id,
878 const MediaSource::Id& source_id) const { 884 const MediaSource::Id& source_id) const {
879 RenderFrameHostId render_frame_host_id(render_process_id, render_frame_id); 885 RenderFrameHostId render_frame_host_id(render_process_id, render_frame_id);
880 return frame_manager_->HasScreenAvailabilityListenerForTest( 886 return frame_manager_->HasScreenAvailabilityListenerForTest(
881 render_frame_host_id, source_id); 887 render_frame_host_id, source_id);
882 } 888 }
883 889
884 } // namespace media_router 890 } // namespace media_router
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698