[memory-infra] Move 'infos' field from Attribute to MemoryAllocatorDump

[memory-infra] Move 'infos' field from Attribute to MemoryAllocatorDump

We want to switch from the memory-infra-specific Attribute class to the
Catapult-wide tr.v.ScalarNumeric class in the near future. The latter
does not support infos and the feature is currently only used for
warnings about the 'size' attribute anyway, so we're moving infos to the
associated MemoryAllocatorDump:

  dump.attrs['size'].infos ----> dump.infos

This also allows us to remove the unnecessary attribute cloning methods
(the list of infos used to be modified in the UI) since attributes are
now treated as immutable (just like numerics).

BUG=catapult:#1928

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/00ce707f6ced1c7bb35315fc23a446d4a0643f9c

[petrcermak, 2016-02-26 18:29:41]

petrcermak@chromium.org changed reviewers:
+ primiano@chromium.org

[petrcermak, 2016-02-26 18:29:42]

Hi,

Please review this patch.

Thanks,
Petr

[Primiano Tucci (use gerrit), 2016-02-29 16:59:57]

LGTM thanks

https://codereview.chromium.org/1744563002/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/memory_dump_allocator_details_pane_test.html
(right):

https://codereview.chromium.org/1744563002/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/memory_dump_allocator_details_pane_test.html:871:
[undefined, SUBALLOCATION_CONTEXT, SUBALLOCATION_CONTEXT,
is this intended? Not sure what the original arg list was, just doule checking
that this is not a copy/paste accident

[petrcermak, 2016-02-29 18:14:25]

Description was changed from

==========
[memory-infra] Move 'infos' field from Attribute to MemoryAllocatorDump

We want to switch from the memory-infra-specific Attribute class to the
Catapult-wide tr.v.ScalarNumeric class in the near future. The latter
does not support infos and the feature is currently used for warnings
about the 'size' attribute anyway, so we're moving infos to the
associated MemoryAllocatorDump:

  dump.attrs['size'].infos ----> dump.infos

This also allows us to remove the unnecessary attribute cloning methods
(the list of infos used to be modified in the UI) since attributes are
now treated as immutable (just like numerics).

BUG=catapult:#1928
==========

to

==========
[memory-infra] Move 'infos' field from Attribute to MemoryAllocatorDump

We want to switch from the memory-infra-specific Attribute class to the
Catapult-wide tr.v.ScalarNumeric class in the near future. The latter
does not support infos and the feature is currently only used for
warnings about the 'size' attribute anyway, so we're moving infos to the
associated MemoryAllocatorDump:

  dump.attrs['size'].infos ----> dump.infos

This also allows us to remove the unnecessary attribute cloning methods
(the list of infos used to be modified in the UI) since attributes are
now treated as immutable (just like numerics).

BUG=catapult:#1928
==========

[petrcermak, 2016-02-29 18:14:39]

Thanks for your comment.

Petr

https://codereview.chromium.org/1744563002/diff/1/tracing/tracing/ui/analysis...
File tracing/tracing/ui/analysis/memory_dump_allocator_details_pane_test.html
(right):

https://codereview.chromium.org/1744563002/diff/1/tracing/tracing/ui/analysis...
tracing/tracing/ui/analysis/memory_dump_allocator_details_pane_test.html:871:
[undefined, SUBALLOCATION_CONTEXT, SUBALLOCATION_CONTEXT,
On 2016/02/29 16:59:57, Primiano (throttled til Mar 4) wrote:
> is this intended? Not sure what the original arg list was, just doule checking
> that this is not a copy/paste accident

Interesting. I suspect this was due to the fact that I merged some old test
cases. It would work both ways, but I suppose there's no reason to change it, so
I'm sticking to the old way. Thanks for spotting this!

[petrcermak, 2016-02-29 18:14:44]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-02-29 18:14:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1744563002/#ps20001
(title: "Address Primiano's comment")

[commit-bot: I haz the power, 2016-02-29 18:14:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1744563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1744563002/20001

[commit-bot: I haz the power, 2016-02-29 18:28:06]

Description was changed from

==========
[memory-infra] Move 'infos' field from Attribute to MemoryAllocatorDump

We want to switch from the memory-infra-specific Attribute class to the
Catapult-wide tr.v.ScalarNumeric class in the near future. The latter
does not support infos and the feature is currently only used for
warnings about the 'size' attribute anyway, so we're moving infos to the
associated MemoryAllocatorDump:

  dump.attrs['size'].infos ----> dump.infos

This also allows us to remove the unnecessary attribute cloning methods
(the list of infos used to be modified in the UI) since attributes are
now treated as immutable (just like numerics).

BUG=catapult:#1928
==========

to

==========
[memory-infra] Move 'infos' field from Attribute to MemoryAllocatorDump

We want to switch from the memory-infra-specific Attribute class to the
Catapult-wide tr.v.ScalarNumeric class in the near future. The latter
does not support infos and the feature is currently only used for
warnings about the 'size' attribute anyway, so we're moving infos to the
associated MemoryAllocatorDump:

  dump.attrs['size'].infos ----> dump.infos

This also allows us to remove the unnecessary attribute cloning methods
(the list of infos used to be modified in the UI) since attributes are
now treated as immutable (just like numerics).

BUG=catapult:#1928

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-02-29 18:28:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...